Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add support for an optional observable as a step property to be called prior to showing the step #469

Open
mwamufiya opened this issue Jan 4, 2022 · 1 comment

Comments

@mwamufiya
Copy link

Feature
There is a need in the project I'm working for the side bar on the home page to be included in the onboarding for the user.
however, this sidebar is by default collapsed. and only when the user clicks on the 'hamburger' icon does the side bar expand to show the menu items.

Currently there is no way to configure the step in joyride to 'pause' the joy ride in-between steps so that I can programmatically open the side bar, then resume the step sequence

Feature Details:

  • add an optional property in the step definition that accept an observable.
  • i.e. dependency (or some better name)
  • in the JoyrideStepService service, if an observable has been defined, THEN
  • this observable should first be called
  • upon completion of this observable, the step should then proceed to try and show the step

this would provide a 'hook' in between steps for applications to add custom logic without complicating the internals of joyride.

since the observable might change the scroll and position of the next step, it should likely be initiated prior to initviewPortPosition

@d4nielix
Copy link

Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants