Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links should expose valid port assigned to ingress controller #113

Open
Marx2 opened this issue Jan 19, 2023 · 0 comments
Open

Links should expose valid port assigned to ingress controller #113

Marx2 opened this issue Jan 19, 2023 · 0 comments

Comments

@Marx2
Copy link

Marx2 commented Jan 19, 2023

Describe the bug
Currently automatically generated links point into 443 port (via https prefix). If there's more ingress controllers, they use different ports. So some links are incorrect, because misses valid port

To Reproduce
Steps to reproduce the behavior:

  1. Expose ingress controller on port different than default 443
  2. Links are generated with 443 port
  3. Links doesn't work

Expected behavior
Links should be created with valid port. As we can have multiple ingress controllers supporting the same ingress, we don't know which port to choose, so the easiest way would be to allow to override default 443 port via annotation like:
hajimari.io/port: "2000"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant