Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart doesn't trigger config reload #82

Open
jbergler opened this issue Oct 16, 2022 · 2 comments · May be fixed by #92
Open

Helm chart doesn't trigger config reload #82

jbergler opened this issue Oct 16, 2022 · 2 comments · May be fixed by #92

Comments

@jbergler
Copy link

Describe the bug
When changes are made to just the hajimari config in the help chart, eg turning showAppUrls off the container does not pick up the config change automatically

To Reproduce
Steps to reproduce the behavior:

  1. Deploy helm chart
  2. Make a change to showAppUrls in values.yaml
  3. Wait until chart is deployed (via flux)
  4. Refresh hajimari, config is not updated
  5. Delete pod, and let it restart
  6. Config is updated

Expected behavior
Changing the config should either restart the pod or otherwise trigger a reload of the config.

@ullbergm ullbergm linked a pull request Oct 30, 2022 that will close this issue
@maaft
Copy link

maaft commented Dec 22, 2022

@toboshii could you please review above PR? This bug is a bit annoying.

@agrrh
Copy link
Contributor

agrrh commented Feb 12, 2023

It's also possible to solve the issue using third-party updaters, e.g. stakater/reloader.

After installing it, Hajimari chart's values need to be populated with following block:

controller:
  annotations:
    configmap.reloader.stakater.com/reload: "hajimari-settings"

But I'm looking forward for PR above to be merged as more suitable solution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants