Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missign injectable in directive with Classes #153

Open
bastienmoulia opened this issue Mar 20, 2017 · 0 comments
Open

Missign injectable in directive with Classes #153

bastienmoulia opened this issue Mar 20, 2017 · 0 comments

Comments

@bastienmoulia
Copy link
Contributor

Following https://github.com/toddmotto/angular-styleguide/blob/master/README.md#constants-or-classes

When i want to use a Class in directives I think the injectable should be added to the module:

export const TodoModule = angular
  .module('todo', [])
  .component('todo', TodoComponent)
  .directive('todoAutofocus', () => new TodoAutoFocus())
  .name;

must be

export const TodoModule = angular
  .module('todo', [])
  .component('todo', TodoComponent)
  .directive('todoAutofocus', ['$timeout', ($timeout) => new TodoAutoFocus($timeout)])
  .name;

to avoid the message error TS2346: Supplied parameters do not match any signature of call target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant