Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database): can't edit database side layout title #6875

Conversation

golok727
Copy link
Contributor

@golok727 golok727 commented Apr 25, 2024

Related to #6858
Closes #6832 (1)

Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ❌ Failed (Inspect) Apr 29, 2024 10:55am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 10:55am

Copy link

graphite-app bot commented Apr 25, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

@golok727 golok727 changed the title fix(database): can't edit in database side layout title fix(database): can't edit database side layout title Apr 25, 2024
@golok727 golok727 marked this pull request as draft April 25, 2024 08:58
@zzj3720
Copy link
Member

zzj3720 commented Apr 25, 2024

The root cause of this bug is using renderModel to render single block. According to the current technical plan, it should be replaced with renderSpecPortal. However, I'm not sure how to use renderSpecPortal to only render a block that nested inside a database block. I need to discuss this with @Saul-Mirone.

@golok727 golok727 marked this pull request as draft April 25, 2024 11:54
@golok727
Copy link
Contributor Author

@zzj3720 should I close this for now ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

​Some bugs about tables
2 participants