Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code markup does not take care of link #6986

Closed
alissa-tung opened this issue May 8, 2024 · 1 comment · Fixed by #6998
Closed

code markup does not take care of link #6986

alissa-tung opened this issue May 8, 2024 · 1 comment · Fixed by #6998
Assignees
@Flrande
Labels
mod:rich-text Module: related to rich-text editing (including Virgo) type:bug Something isn't working

Comments

@alissa-tung
Copy link

alissa-tung commented May 8, 2024 •
edited

  • if a text is marked as code, than link, it will lose the code format
  • if a text is marked as link, than code, it will lose the blue color to suggest it is clickable, which makes some inconsistent; also the font size would change
@Flrande Flrande self-assigned this May 8, 2024
@Flrande Flrande added mod:rich-text Module: related to rich-text editing (including Virgo) type:bug Something isn't working labels May 8, 2024
@Flrande Flrande mentioned this issue May 9, 2024
Merged
Saul-Mirone pushed a commit that referenced this issue May 10, 2024
@Flrande
fix(blocks): support overlapping of inline styles (#6998)
b5e411a 
Close #6986

https://github.com/toeverything/blocksuite/assets/50035259/a425bc24-b87e-45c3-90e9-cf02d339c61f
@Flrande
Copy link
Member

Flrande commented May 11, 2024

fixed in #6998

@Flrande Flrande closed this as completed May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Flrande Flrande

Labels
mod:rich-text Module: related to rich-text editing (including Virgo) type:bug Something isn't working
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(blocks): support overlapping of inline styles toeverything/blocksuite
2 participants
@Flrande @alissa-tung