Skip to content

Commit

Permalink
feat: addAttributeCTI option, add parseTokens funtions, swap args
Browse files Browse the repository at this point in the history
  • Loading branch information
jorenbroekema committed Nov 16, 2023
1 parent 64de4b8 commit 6f4b5ed
Show file tree
Hide file tree
Showing 11 changed files with 82 additions and 35 deletions.
5 changes: 5 additions & 0 deletions .changeset/fuzzy-beers-sell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tokens-studio/sd-transforms': minor
---

BREAKING: swap expandComposites 2nd argument and 3rd argument. 2nd argument is now TransformOptions and 3rd argument the filePath (string). This used to be vice versa and was inconsistent with the other parser functions.
5 changes: 5 additions & 0 deletions .changeset/nice-tips-attack.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tokens-studio/sd-transforms': minor
---

Add and expose a parseTokens function to make it more developer friendly to add the sd-transforms parsing step to your own custom parser.
5 changes: 5 additions & 0 deletions .changeset/silver-lobsters-know.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tokens-studio/sd-transforms': minor
---

Add the addAttributeCTI option to registerTransforms function, to automatically add `attribute/cti` predefined transform to the `tokens-studio` transformGroup.
48 changes: 26 additions & 22 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
- [Using the transforms](#using-the-transforms)
- [Custom Transform Group](#custom-transform-group)
- [Options](#options)
- [Full example](#full-example)
- [Themes full example](#themes-full-example)
- [Complete example](#full-example)
- [Themes complete example](#themes-complete-example)
- [Multi-dimensional theming](#multi-dimensional-theming)
- [Transforms](#transforms)
- [Troubleshooting](#not-sure-how-to-fix-your-issue)
Expand Down Expand Up @@ -112,7 +112,7 @@ StyleDictionary.registerTransform({

In Style-Dictionary, [`transformGroup` and `transforms` cannot be combined in a platform inside your config](https://github.com/amzn/style-dictionary/issues/813).

Therefore, if you wish to use the transform group, but adjust, add or remove a few transforms, your best option is creating a custom transformGroup:
Therefore, if you wish to use the transform group, but adjust, add or remove a few transforms, your best option is to create a custom transform group:

```js
const { transforms } = require('@tokens-studio/sd-transforms');
Expand All @@ -127,6 +127,9 @@ StyleDictionary.registerTransformGroup({
});
```

> Note: it is easy to change the casing or to add attributes/cti transform to the group, without needing to create a custom transform group.
> For this, see section "Options" below for the `casing` and `addAttributeCTI` option.
### Options

You can pass options to the `registerTransforms` function.
Expand All @@ -152,6 +155,7 @@ Options:
| name | type | required | default | description |
| ----------------------------- | ------------------------ | -------- | --------------- | ------------------------------------------------------------------------------------------------------------------------------------- |
| excludeParentKeys | boolean || `false` | Whether or not to exclude parent keys from your token files |
| addAttributeCTI | boolean || `false` | Whether or not to add `'attribute/cti'` predefined transform to the `tokens-studio` transformGroup |
| alwaysAddFontStyle | boolean || `false` | Whether or not to always add a 'normal' fontStyle property to typography tokens which do not have explicit fontStyle |
| casing | string || `camel` | What kind of casing to use for token names. Options: [`camel`, `pascal`, `snake`, `kebab`, `constant`] |
| expand | boolean \| ExpandOptions || See props below | `false` to not register the parser at all. By default, expands composition tokens. Optionally, border, shadow and typography as well. |
Expand All @@ -163,8 +167,8 @@ Options:
| ['ts/color/modifiers'].format | ColorModifierFormat || `undefined` | Color modifier output format override ('hex' \| 'hsl' \| 'lch' \| 'p3' \| 'srgb'), uses local format or modifier space as default |
| |

> Note: you can also import and use the `expandComposites` function to run the expansion on your token object manually.
> Handy if you have your own parsers set up (e.g. for JS files), and you want the expansions to work there too.
> Note: you can also import and use the `parseTokens` function to run the parsing steps on your tokens object manually.
> Handy if you have your own parsers set up (e.g. for JS files), and you want the parser-based features like composites-expansion to work there too.
## Full example

Expand Down Expand Up @@ -221,7 +225,7 @@ sd.cleanAllPlatforms();
sd.buildAllPlatforms();
```

#### To run it use following command
To run it use the following command

```sh
node build-output.js
Expand All @@ -230,7 +234,7 @@ node build-output.js
> Note: make sure to choose either the full transformGroup, **OR** its separate transforms so you can adjust or add your own.
> [Combining a transformGroup with a transforms array can give unexpected results](https://github.com/amzn/style-dictionary/issues/813).
### Themes full example
### Themes: complete example

You might be using Themes in the PRO version of Tokens Studio.

Expand Down Expand Up @@ -378,7 +382,7 @@ run();

### ts/descriptionToComment

This transform maps token descriptions to comments.
This transform maps token descriptions into comments.

**matches**: All tokens that have a description property.

Expand Down Expand Up @@ -443,7 +447,7 @@ This transform checks and evaluates math expressions

### ts/size/px

This transform adds `px` as a unit when missing to tokens.
This transform adds `px` as a unit when dimension-like tokens do not have a unit.

**matches**: `token.type` is one of `['sizing', 'spacing', 'borderRadius', 'borderWidth', 'fontSizes', 'dimension']`

Expand Down Expand Up @@ -471,7 +475,7 @@ This transform adds `px` as a unit when missing to tokens.

### ts/opacity

This transforms opacity token values declared with `%` to a number between `0` and `1`.
This transforms opacity token values declared with `%` into a number between `0` and `1`.

**matches**: `token.type` is `'opacity'`

Expand Down Expand Up @@ -499,7 +503,7 @@ This transforms opacity token values declared with `%` to a number between `0` a

### ts/size/lineheight

This transforms line-height token values declared with `%` to a a unitless value.
This transforms line-height token values declared with `%` into a unitless value.

**matches**: `token.type` is `'lineHeights'`

Expand Down Expand Up @@ -645,7 +649,7 @@ This transforms letter-spacing token values declared with `%` to a value with `e

### ts/color/css/hexrgba

This transforms color token values with Figma's "hex code RGBA" to an actual `rgba()` format
This transforms color token values with Figma's "hex code RGBA" into actual `rgba()` format

**matches**: `token.type` is `'color'`

Expand Down Expand Up @@ -701,7 +705,7 @@ This transforms font-family token values into valid CSS, adding single quotes if

### ts/typography/css/shorthand

This transforms typography tokens to a valid CSS shorthand
This transforms typography tokens into a valid CSS shorthand

**matches**: `token.type` is `'typography'`

Expand Down Expand Up @@ -733,7 +737,7 @@ This transforms typography tokens to a valid CSS shorthand

### ts/shadow/css/shorthand

This transforms shadow tokens to a valid CSS shadow shorthand
This transforms shadow tokens into a valid CSS shadow shorthand

**matches**: `token.type` is `'boxShadow'`

Expand Down Expand Up @@ -766,7 +770,7 @@ This transforms shadow tokens to a valid CSS shadow shorthand

### ts/border/css/shorthand

This transforms border tokens to a valid CSS border shorthand
This transforms border tokens into a valid CSS border shorthand

**matches**: `token.type` is `'border'`

Expand Down Expand Up @@ -795,13 +799,13 @@ This transforms border tokens to a valid CSS border shorthand
}
```

## Not sure how to fix your issue ?
## Not sure how to fix your issue?

### Create a reproduction by :-
### Create a reproduction by:-

1. Open configurator tool [link](https://configurator.tokens.studio/)
1. Open the configurator tool [link](https://configurator.tokens.studio/)
2. Upload your tokens and add your style dictionary config and transforms
3. Copy the Url as it will include your settings.
4. Join our slack [link](https://tokens.studio/slack)
5. Open style-dictionary-configurator channel.
6. Create a thread about your issue and paste your reproduction link inside it.
3. Copy the URL as it will include your settings
4. Join our Slack [link](https://tokens.studio/slack)
5. Open style-dictionary-configurator channel
6. Create a thread about your issue and paste your reproduction link inside it
3 changes: 2 additions & 1 deletion src/TransformOptions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export type Expandables =
export const expandablesAsStringsArr = ['composition', 'typography', 'border', 'boxShadow'];
export type ExpandablesAsStrings = (typeof expandablesAsStringsArr)[number];

export type ExpandFilter<T extends SingleToken> = (token: T, filePath: string) => boolean;
export type ExpandFilter<T extends SingleToken> = (token: T, filePath?: string) => boolean;

export interface ExpandOptions {
typography?: boolean | ExpandFilter<SingleTypographyToken>; // default false
Expand All @@ -31,6 +31,7 @@ export interface ColorModifierOptions {
}

export interface TransformOptions {
addAttributeCTI?: boolean;
casing?: 'camel' | 'pascal' | 'snake' | 'kebab' | 'constant';
alwaysAddFontStyle?: boolean;
expand?: ExpandOptions | false;
Expand Down
1 change: 1 addition & 0 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ export { transforms } from './registerTransforms.js';
export { expandComposites } from './parsers/expand-composites.js';
export { excludeParentKeys } from './parsers/exclude-parent-keys.js';
export { addFontStyles } from './parsers/add-font-styles.js';
export { parseTokens } from './parsers/parse-tokens.js';

export { mapDescriptionToComment } from './mapDescriptionToComment.js';
export { checkAndEvaluateMath } from './checkAndEvaluateMath.js';
Expand Down
10 changes: 5 additions & 5 deletions src/parsers/expand-composites.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export function expandToken(compToken: SingleToken<false>, isShadow = false): Si
function shouldExpand<T extends SingleToken>(
token: T,
condition: boolean | ExpandFilter<T>,
filePath: string,
filePath?: string,
): boolean {
if (typeof condition === 'function') {
return condition(token, filePath);
Expand All @@ -75,8 +75,8 @@ function shouldExpand<T extends SingleToken>(
function recurse(
slice: DeepKeyTokenMap<false> | SingleToken<false>,
copy: DeepKeyTokenMap<false> | SingleToken<false>,
filePath: string,
transformOpts: TransformOptions = {},
filePath?: string,
) {
const opts = {
...transformOpts,
Expand Down Expand Up @@ -110,17 +110,17 @@ function recurse(
}
}
} else {
recurse(token, copy, filePath, transformOpts);
recurse(token, copy, transformOpts, filePath);
}
}
}

export function expandComposites(
dictionary: DeepKeyTokenMap<false> | SingleToken<false>,
filePath: string,
transformOpts?: TransformOptions,
filePath?: string,
): DeepKeyTokenMap<false> | SingleToken<false> {
const copy = { ...dictionary };
recurse(copy, copy, filePath, transformOpts);
recurse(copy, copy, transformOpts, filePath);
return copy;
}
16 changes: 16 additions & 0 deletions src/parsers/parse-tokens.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import { DeepKeyTokenMap } from '@tokens-studio/types';
import { TransformOptions } from '../TransformOptions.js';
import { excludeParentKeys } from './exclude-parent-keys.js';
import { addFontStyles } from './add-font-styles.js';
import { expandComposites } from './expand-composites.js';

export function parseTokens(
tokens: DeepKeyTokenMap<false>,
transformOpts?: TransformOptions,
filePath?: string,
) {
const excluded = excludeParentKeys(tokens, transformOpts);
const withFontStyles = addFontStyles(excluded, transformOpts);
const expanded = expandComposites(withFontStyles, transformOpts, filePath);
return expanded;
}
9 changes: 4 additions & 5 deletions src/registerTransforms.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import { expandComposites } from './parsers/expand-composites.js';
import { excludeParentKeys } from './parsers/exclude-parent-keys.js';
import { transformOpacity } from './transformOpacity.js';
import { addFontStyles } from './parsers/add-font-styles.js';
import { parseTokens } from './parsers/parse-tokens.js';

const isBrowser = typeof window === 'object';

Expand Down Expand Up @@ -58,11 +59,8 @@ export async function registerTransforms(sd: Core, transformOpts?: TransformOpti
_sd.registerParser({
pattern: /\.json$/,
parse: ({ filePath, contents }) => {
const obj = JSON.parse(contents);
const excluded = excludeParentKeys(obj, transformOpts);
const withFontStyles = addFontStyles(excluded, transformOpts);
const expanded = expandComposites(withFontStyles, filePath, transformOpts);
return expanded as DesignTokens;
const tokens = JSON.parse(contents);
return parseTokens(tokens, transformOpts, filePath) as DesignTokens;
},
});
}
Expand Down Expand Up @@ -195,6 +193,7 @@ export async function registerTransforms(sd: Core, transformOpts?: TransformOpti
_sd.registerTransformGroup({
name: 'tokens-studio',
transforms: [
...(transformOpts?.addAttributeCTI === true ? ['attribute/cti'] : []),
...transforms,
// by default we go with camel, as having no default will likely give the user
// errors straight away. This can be overridden by manually passing an array of transforms
Expand Down
12 changes: 12 additions & 0 deletions test/integration/sd-transforms.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -124,4 +124,16 @@ describe('sd-transforms smoke tests', () => {
--sd-uses-color: rgba(255, 0, 255, 1);
}`);
});

it('allows easily adding attribute/cti transform to tokens-studio group', async () => {
if (dict) {
cleanup(dict);
}
dict = init(cfg, { 'ts/color/modifiers': { format: 'hex' }, addAttributeCTI: true });
const enrichedTokens = dict.exportPlatform('css'); // platform to parse for is 'css' in this case
expect(enrichedTokens.dimension.scale.attributes).to.eql({
category: 'dimension',
type: 'scale',
});
});
});
3 changes: 1 addition & 2 deletions test/integration/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ import { registerTransforms } from '../../src/registerTransforms.js';
export function init(cfg: Config, transformOpts = {}) {
registerTransforms(StyleDictionary, transformOpts);
const dict = StyleDictionary.extend(cfg);
dict.buildAllPlatforms();
return dict;
return dict.buildAllPlatforms();
}

export function cleanup(dict: StyleDictionary.Core) {
Expand Down

0 comments on commit 6f4b5ed

Please sign in to comment.