Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override put_slice for &mut [u8] #483

Merged
merged 1 commit into from Feb 16, 2021
Merged

Override put_slice for &mut [u8] #483

merged 1 commit into from Feb 16, 2021

Conversation

Zettroke
Copy link
Contributor

Noticed non optimal assembly generated when using BufMut with &mut [u8] slices.
playground

After further investigation add override for put_slice in &mut [u8] implementation.

seanmonstar
seanmonstar approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@seanmonstar seanmonstar merged commit 268f6f8 into tokio-rs:master Feb 16, 2021
@Darksonn Darksonn mentioned this pull request Aug 25, 2021
Merged
lelongg pushed a commit to lelongg/bytes that referenced this pull request Jan 9, 2023
@Zettroke @lelongg
override put_slice for &mut [u8] (tokio-rs#483)
d8d398b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zettroke @seanmonstar