Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

const-ify Bytes::len and Bytes::is_empty #514

Merged
merged 2 commits into from Nov 9, 2021

Conversation

Cyborus04
Copy link
Contributor

No description provided.

@Cyborus04

This comment has been minimized.

@Cyborus04 Cyborus04 changed the title const-ify Bytes::from_static and Bytes::len const-ify Bytes::len Nov 6, 2021
@Cyborus04 Cyborus04 changed the title const-ify Bytes::len const-ify Bytes::len and Bytes::is_empty Nov 6, 2021
@Cyborus04
Copy link
Contributor Author

I'm not sure what's going on in the miri check, but AFAICT it's not related

@Noah-Kennedy
Copy link
Contributor

It isn't, I think miri got some new lints

Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once #515 is merged, you should be able to merge in master to fix CI.

@Noah-Kennedy
Copy link
Contributor

Noah-Kennedy commented Nov 7, 2021

#515 is merged, you can go ahead and merge in the changes from master now.

@Darksonn Darksonn merged commit d946ef2 into tokio-rs:master Nov 9, 2021
@Cyborus04 Cyborus04 deleted the constify branch November 11, 2021 17:09
lelongg pushed a commit to lelongg/bytes that referenced this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants