Clarify BytesMut::unsplit docs #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
reviewed
Mar 16, 2022
src/bytes_mut.rs
Outdated
Comment on lines
736
to
739
| /// If the two `BytesMut` objects were previously contiguous and not mutated | ||
| /// in a way that causes re-allocation. | ||
| /// i.e., if `other` was created by calling `split_off` on this `BytesMut`, | ||
| /// then this is an `O(1)` operation that just decreases a reference |
There was a problem hiding this comment.
This sentence seems a bit broken - there's a period in the middle of a sentence.
There was a problem hiding this comment.
OK, I removed the period
Darksonn
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #532