New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TSAN support #541
Add TSAN support #541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, should we consider defining an acquire!
macro? e.g. https://doc.rust-lang.org/stable/src/alloc/sync.rs.html#1637
Meh, not sure the macro adds that much. |
src/bytes_mut.rs
Outdated
// Thread sanitizer does not support atomic fences. Use an atomic load | ||
// instead. | ||
//#[cfg(thread = "sanitize")] | ||
//(*ptr).ref_count.load(Ordering::Acquire); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like everything is commented out.
Originally I had misspelled |
Was previously attempted in #405, but that PR was closed due to TSAN detection being unstable.
Closes: #540