Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application logs section when using tokio-console #297

Open
Milo123459 opened this issue Feb 26, 2022 · 2 comments
Open

Add application logs section when using tokio-console #297

Milo123459 opened this issue Feb 26, 2022 · 2 comments
Labels
E-medium Effort: medium. S-feature Severity: feature. This is adding a new feature.

Comments

@Milo123459
Copy link
Contributor

Something to see & filter the logs from your application.

@hawkw hawkw added E-medium Effort: medium. S-feature Severity: feature. This is adding a new feature. labels Feb 26, 2022
@hawkw
Copy link
Member

hawkw commented Feb 26, 2022

Yeah, we'd definitely like to eventually have a way to stream a log of all tracing events from the program. One thing we've also considered is adding a way to filter event logs by task, and display a log of all the events that occurred within a particular task in the Task Details view. Of course, we could also show event logs for all tasks,

Some design considerations:

  • This should probably be a separate RPC than the main Instrument::watch_updates RPC. We're already streaming a lot of data from the instrumented application, and most of the views the console currently provides probably won't display logs by default. Therefore, we'll probably want to have a way to toggle on and off log streams separately from other data streams, so that we're only streaming them as needed.
  • How would we want to filter what logs are displayed?
  • Since we can stream logs as structured data rather than as strings, we can probably display them in some much more interesting ways than just a bunch of lines of text --- e.g. some data can be conditionally hidden or shown. However, we probably want to start with something simple and then iterate on it.

@Milo123459
Copy link
Contributor Author

Filtering should just be pressing ctrl+f and showing a text box

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-medium Effort: medium. S-feature Severity: feature. This is adding a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants