Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idle tasks disappearing after restart #362

Open
cameronelliott opened this issue Jul 18, 2022 · 4 comments
Open

Idle tasks disappearing after restart #362

cameronelliott opened this issue Jul 18, 2022 · 4 comments
Labels
S-bug Severity: bug

Comments

@cameronelliott
Copy link

cameronelliott commented Jul 18, 2022

What crate(s) in this repo are involved in the problem?

tokio-console

What is the issue?

When stopping, and then re-starting tokio-console, a number of idle tasks are dropped from the task list, in situations where the task list is in a steady-state, and not changing.

I made a video to show what is happening, it seems like it might be a bug or something, I am not sure.

view online (low fidelity):
https://www.dropbox.com/s/glmi76mnqux5zv2/console%20q%202.mp4?dl=0

download for viewing (high fidelity, but 93MB)
https://www.dropbox.com/s/glmi76mnqux5zv2/console%20q%202.mp4?dl=1

How can the bug be reproduced?

This repo creates two WebRTC engines:
https://github.com/cameronelliott/webrtc-futures-leak

It has three stdin new-line prompts to allow entering the three states of the program:

press enter once - start webrtc stuff
press enter again - close both webrtc engines
press enter again - webrtc engines go out of scope

Logs, error output, etc

No response

Versions

├── console-subscriber v0.1.6
│ ├── console-api v0.3.0

Possible solution

Don't know

Additional context

Possibly lack of understanding of how console works on my part.

Would you like to work on fixing this bug?

maybe

@cameronelliott cameronelliott added the S-bug Severity: bug label Jul 18, 2022
@hawkw
Copy link
Member

hawkw commented Jul 18, 2022

Thanks, I watched the video you've attached, and this definitely seems like a bug to me. I'm assuming that shutting down the WebRTC engines caused a number of those tasks to terminate, but this wasn't reflected in the console that was already connected for some reason. The newly connected console seems to have displayed the actual correct state.

I'm not sure what's going on here, and I've never seen this happen before, so it definitely seems like something we should investigate.

Out of interest, I notice that you included the version numbers for console-subscriber and console-api in the report. What version is the tokio-console command line application? You can access that by running tokio-console --version.

@lolgesten
Copy link

Hi! I reproed this on my end too (after chatting with @cameronelliott yesterday) – again using webrtc-rs, but a completely different implementation than the above repo.

My version is tokio-console 0.1.6

@cameronelliott
Copy link
Author

I just checked, my version is also tokio-console 0.1.6

@hawkw
Copy link
Member

hawkw commented Jul 18, 2022

Great, thanks for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-bug Severity: bug
Projects
None yet
Development

No branches or pull requests

3 participants