Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation failure regression on x86_64-fortanix-unknown-sgx target #4999

Closed
kostko opened this issue Sep 12, 2022 · 3 comments · Fixed by #5000
Closed

Compilation failure regression on x86_64-fortanix-unknown-sgx target #4999

kostko opened this issue Sep 12, 2022 · 3 comments · Fixed by #5000
Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug.

Comments

@kostko
Copy link
Contributor

kostko commented Sep 12, 2022

With tokio 1.20.1 it was possible to build for the x86_64-fortanix-unknown-sgx target when not using the net feature since the socket2 dependency was optional and only enabled when net was enabled. With tokio 1.21.0 compilation now fails due to socket2 being required and built with the all feature flag which is not supported on the x86_64-fortanix-unknown-sgx target.

Could socket2 be removed as a dependency on x86_64-fortanix-unknown-sgx similar to how it is now on wasm* targets or if there is another course of action that would be more suitable to ensure compilation on x86_64-fortanix-unknown-sgx?

@kostko kostko added A-tokio Area: The main tokio crate C-bug Category: This is a bug. labels Sep 12, 2022
@carllerche
Copy link
Member

Is there a way to add a cross-compilation check for this platform in CI? @kostko is that something you could submit a PR for?

@kostko
Copy link
Contributor Author

kostko commented Sep 12, 2022

Sure, just opened #5001 (need to test if it works on CI after the workflow gets approved). The test is just a simple build test as actually running some unit tests requires SGX hardware (and therefore some custom GitHub runners).

@kostko
Copy link
Contributor Author

kostko commented Sep 12, 2022

And thanks for the quick reply and fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants