Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Angular Material TestHarness in tests #513

Open
tomastrajan opened this issue Feb 20, 2020 · 4 comments
Open

Use Angular Material TestHarness in tests #513

tomastrajan opened this issue Feb 20, 2020 · 4 comments
Labels
enhancement 🎁 good first issue 🥇 help wanted 👋

Comments

@tomastrajan
Copy link
Owner

It would be great to migrate tests to use new Angular Material Component Test Harness in the unit tests.

The migration should be mostly mechanical as it's basically replacing ad-hoc selectors with the selectors provided by the @angular/cdk.

Test can be run in watch mode using npm run watch...
@tomastrajan
Copy link
Owner Author

Please write comment if you wanna migrate some component tests so that we can prevent duplicate effort

@mcanoglu
Copy link
Contributor

Hi! I would like to give it a try.

mcanoglu added a commit to mcanoglu/angular-ngrx-material-starter that referenced this issue Feb 23, 2020
@mcanoglu
test(todo): migrate to material test harness tomastrajan#513
a930512
mcanoglu added a commit to mcanoglu/angular-ngrx-material-starter that referenced this issue Feb 23, 2020
@mcanoglu
test(form): migrate to material test harness tomastrajan#513
32ba7d7
@mcanoglu mcanoglu mentioned this issue Feb 23, 2020
Merged
@tomastrajan
Copy link
Owner Author

@mcanoglu thank you for great contribution!

For others, there are still many components that can be migrated to use TestHarness and now you even have great example of how to do it by @mcanoglu !

@yousafnawaz
Copy link

Hi @tomastrajan, I would like to migrate some components to use . https://material.angular.io/guide/using-component-harnesses Angular Material Component Test Harness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 🎁 good first issue 🥇 help wanted 👋
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tomastrajan @mcanoglu @yousafnawaz