Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React 16 #124

Open
zhangjunah opened this issue Sep 27, 2017 · 2 comments
Open

Support React 16 #124

zhangjunah opened this issue Sep 27, 2017 · 2 comments

Comments

@zhangjunah
Copy link

When I set my package.json like this:

"dependencies": {
  "react-dom": "^16.0.0",
  "react": "^16.0.0",
  "react-toastr": "^2.9.3"
}

Then I run npm i, the node_modules/react-toastr/node_modules/react-dom is installed, this means npm install a react-dom 15.6 for react-toastr. So, when I run my app, it is crashed, but if I remove the dir node_modules/react-toastr/node_modules/, everything runs well.

I hope you to publish a new version to support React 16, in fact, I think all the code runs well on React 16, only need to change the package.json

@mclapa
Copy link

mclapa commented Oct 12, 2017

@zhangjunah might explain this error I'm getting

Element ref was specified as a string (toasts__0) but no owner was set. You may have multiple copies of React loaded.

@whns
Copy link
Contributor

whns commented Oct 13, 2017

Is this still happening with version 2.9.5?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants