Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new ChordSymbol module #168

Open
danigb opened this issue Apr 27, 2020 · 4 comments
Open

Add a new ChordSymbol module #168

danigb opened this issue Apr 27, 2020 · 4 comments

Comments

@danigb
Copy link
Collaborator

danigb commented Apr 27, 2020

Add a module to parse chord symbols. Will replace the actual Chord.tokenize function but implementing chord roots (aka slashed chords).

It should fix most of the issues of #155

@martijnmichel
Copy link
Contributor

martijnmichel commented May 15, 2020

Would it be nice to have a custom font for tonal js where musical signs get pasted correctly on all browsers? When making Sonid I ran into the issue that the flat/sharp (and others) signs had different spacing and sizes on different OSses.

After a bit of experimenting I found that using a custom font with svg glyphs and setting them in a span with css content solved the issue. It might nice to include a property which pastes names with musical signs inside all notes/chords/scales objects. Although, come to think of it, it would have to be multilanguage aswell...

@Euthymious
Copy link

Would it be nice to have a custom font for tonal js where musical signs get pasted correctly on all browsers?

Maybe this one: https://github.com/larsenwork/monomusic

@no-chris
Copy link

Hello,
Not sure how well it fits your use case but this lib can parse chord-symbols into intervals:
https://github.com/no-chris/chord-symbol
Let me know if any interest, I could assist with the integration

@danigb
Copy link
Collaborator Author

danigb commented Sep 23, 2020

Hi Chris,

You library looks great! Congrats. Anyway, I think it's too complex for what I had in mind. Also some of functionality overlaps with tonal (interval to semitones, note names to name a few) so I think it's better to keep them separated.

Good work and thanks for sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants