Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can create localization? #386

Open
X1Z53 opened this issue Jul 28, 2023 · 2 comments
Open

Can create localization? #386

X1Z53 opened this issue Jul 28, 2023 · 2 comments

Comments

@X1Z53
Copy link

X1Z53 commented Jul 28, 2023

In this article, as I see, half of the languages of the world use such a scale: C-D-E-F-G-A-H to denote the scale in C major. Maybe add a prop to use a similar naming system?
Or does it already exist?

@danigb
Copy link
Collaborator

danigb commented Jul 31, 2023

Interesting... how the API might be? On the other side, a simple search&replace might work for most scenarios (since note names are always in uppercase...)

@X1Z53
Copy link
Author

X1Z53 commented Aug 3, 2023

I use the search and replace method, and I don't see anything critical in it, but on the other hand, it looks like a crutch

So I decided to give you this idea. I thought maybe you would be interested in adding this functionality

As an implementation, I can suggest the transfer of the boolean key useGerman during initialization. If True, use instead of B - H, and instead of Bb - B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants