Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge case with Interval, possibly note octave designation #428

Open
aure opened this issue Apr 4, 2024 · 1 comment
Open

Edge case with Interval, possibly note octave designation #428

aure opened this issue Apr 4, 2024 · 1 comment

Comments

@aure
Copy link

aure commented Apr 4, 2024

Hello, I am one of the authors of a similar package for Swift, Tonic: https://github.com/AudioKit/Tonic

I recently had some issues in my library around the interval between notes in adjacent octaves, and I wanted to test if your library had that solved in a similar way. In my testing, I noticed this problem which must be a bug:

  Tonal.Interval.distance("B#4", "C4");
  Tonal.Interval.distance("B#4", "C5"));

both return "-7A". If you're curious about how we handle octave number, you can check out my reasoning in this issue response: AudioKit/Tonic#26

I'm not a javascript developer or else I would have dug into the code and offered a pull request instead of an issue. I hope this is helpful.

@danigb
Copy link
Collaborator

danigb commented Apr 6, 2024

Interesting... I'll investigate the issue. Thanks a lot for reporting! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants