Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing results from Detect.chord #63

Open
Mdashdotdashn opened this issue Mar 11, 2018 · 4 comments
Open

Confusing results from Detect.chord #63

Mdashdotdashn opened this issue Mar 11, 2018 · 4 comments

Comments

@Mdashdotdashn
Copy link

Calling chord detection returns the '64' form for major chords which I found confusing as I had no idea what it meant.

Detect.chord([ '1P', '3M', '5P' ])
=> detected C64,Em#5
@danigb
Copy link
Collaborator

danigb commented Apr 21, 2018

Yes, agree. This is not a good expected result. Scale names and detection needs a good rework (see #56)

(by the way: https://medium.com/@michaelkaulkin/name-that-chord-the-confusing-world-of-the-cadential-6-4-df58dd6a86cc)

Thanks for reporting!

@RichardJECooke
Copy link

RichardJECooke commented Aug 21, 2018

How do you install Detect please?

I've tried npm install tonal then

const _tonal = require('tonal');
tonal.Detect.chord(['A','C','Eb'];

but Detect isn't part of tonal.

Then I tried npm install tonal-detect, as documented here: https://danigb.github.io/tonal/api/module-Detect.html, but tonal-detect isn't in npm.

Help :(

@danigb
Copy link
Collaborator

danigb commented Aug 22, 2018

Yes, I don't know why it's called tonal-detector. I have to change the name or update the docs.

Anyway, as this issue suggest, chord and scale detection are not working very smoothly.

@btkramer9
Copy link

How is one supposed to use code from the extensions in the browser? Excuse me if it's trivial, i'm very novice with JS. Specifically I'm trying to use Tonal.Detect.chord().

In index.html I use
<script type="text/javascript" src="scripts/tonal.min.js"></script>

and I can call this just fine:
Tonal.Chord.notes("C", "M");

however this is unable to find the chord function :
Tonal.Detect.chord(["C", "E", "G"]);

and I think it's because Detect isn't in the minified distribution. trying to use the import function seems to be an endless pit of issues but I don't think I'm supposed to be using that in the browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants