Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 heights were much better in a terminal with background colors #1579

Open
chrisant996 opened this issue Mar 19, 2024 · 2 comments
Open

v2 heights were much better in a terminal with background colors #1579

chrisant996 opened this issue Mar 19, 2024 · 2 comments
Milestone

Comments

@chrisant996
Copy link

chrisant996 commented Mar 19, 2024

When background colors exist in a terminal, the character cells glyphs within a character cell in Fira Code v6.2 are taller than in v2.0, which causes the tops of characters to be too close to the bottom of the background of text in the line above it.

Is there some way to compile the font using the old v2.0 vertical spacing?

I've been continuing to use v2.0 for years now, because Fira Code is my favorite font but the heights after v2.0 are not as conducive for use in a terminal where background colors are applied.

For example, look at each line with a background color in the screenshot below, versus the line below it. Especially for the [] on the last line in the screenshot. Also, it looks "off" to have half the space above a capital letter as below the capital letter (particularly visible when a run of text has a background color different from the rest of the terminal display).

Also, I just noticed that the vertical position of a strikethrough line is way off in v6.2, at least when rendered by Windows Terminal (look at the green text immediately below the "Debt" line in the screenshot).

image

@tonsky
Copy link
Owner

tonsky commented Mar 19, 2024

I plan to revisit that in v7 and see what can be done. I agree it’s unbalanced

@tonsky tonsky added this to the 7 milestone Mar 19, 2024
@chrisant996
Copy link
Author

@tonsky Thank you for the labor of love that you pour into Fira Code! It's by far my favorite terminal font ever, and I appreciate all the detailed work you put into the ligatures, and things like progress indicators! (JetBrains Mono is my second favorite, for whatever it's worth.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants