Add include-pre-releases configuration option
#1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbinjanssen
changed the title
This was referenced Jan 28, 2023
|
@jetersen ready for review :) |
robbinjanssen
changed the title
exclude-pre-releases configuration option
lib/releases.js
Outdated
| @@ -57,7 +58,9 @@ const findReleases = async ({ | |||
| ? commitishFilteredReleases.filter((r) => r.tag_name.startsWith(tagPrefix)) | |||
| : commitishFilteredReleases | |||
| const sortedPublishedReleases = sortReleases( | |||
| filteredReleases.filter((r) => !r.draft && !r.prerelease) | |||
| filteredReleases.filter( | |||
| (r) => !r.draft && (!excludePreReleases || !r.prerelease) | |||
There was a problem hiding this comment.
Logic checks out, but it doesn't read right.
!r.draft && (!r.prerelease || includePreReleases)
would be preferable.
I'm quite concerned about the amount of boolean logic in this function already which is why I'm even giving this a comment. It probably needs to get reflowed entirely, but that's out of scope here.
There was a problem hiding this comment.
I've changed the configuration to include-pre-releases which makes more sense :) Thanks for your input!
robbinjanssen
changed the title
exclude-pre-releases configuration optioninclude-pre-releases configuration option
blast-hardcheese
approved these changes
Feb 5, 2023
|
@jetersen sorry to poke you, but can you have a look at this PR and decide whether or not you want this at all? |
jetersen
changed the title
include-pre-releases configuration optioninclude-pre-releases configuration option
|
@robbinjanssen Thanks for the PR, sorry for not getting back to you sooner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change introduced in #1240 broke the release flow for some people. By adding a configuration option to
include-pre-releaseswe can make this work for everybody :-) The default isfalseso the behaviour introduced in #1240 will be the default behaviour.tl;dr - If you want to allow pre-releases to count as releases, add
include-pre-releases: trueto your configCloses #1291
Closes #1293
When merging, please squash :-)