Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to Intl namespace types #177

Open
pc-erin opened this issue Nov 15, 2023 · 0 comments
Open

Improvement to Intl namespace types #177

pc-erin opened this issue Nov 15, 2023 · 0 comments

Comments

@pc-erin
Copy link

pc-erin commented Nov 15, 2023

Would anyone else find it useful to add the string type to the number passed to a NumberFormat.format call?

I've been using this with a decimal math library, and am trying to avoid losing any precision while doing math and displaying the end results.

According to MDN it's fine to pass a string to the format method, but the typescript standard lib only types that parameter as number | bigint. So, passing a string, while allowed by the API, still shows a type error.

I can submit a pull request for this if you're willing to accept it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant