Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise when trying to acquire in R/O or missing folder #96

Merged
merged 5 commits into from Sep 30, 2021
Merged

Raise when trying to acquire in R/O or missing folder #96

merged 5 commits into from Sep 30, 2021

Conversation

gaborbernat
Copy link
Member

Signed-off-by: Bernát Gábor gaborjbernat@gmail.com

Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
src/filelock/_soft.py Outdated Show resolved Hide resolved
Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
@gaborbernat
Copy link
Member Author

I'm not sure we can make the soft file lock deadlock safe 🤦 but will keep trying 😟

Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
Copy link
Member Author

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The end result feels hacky, but hey it works 🤷

@gaborbernat gaborbernat merged commit c9b6d90 into tox-dev:main Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants