Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next release v4.62.3 #1246

Merged
merged 15 commits into from
Sep 20, 2021
Merged

next release v4.62.3 #1246

merged 15 commits into from
Sep 20, 2021

Conversation

casperdcl
Copy link
Sponsor Member

@casperdcl casperdcl commented Sep 9, 2021

  • fix minor typo
  • minor example fix
  • misc tidying & refactoring
  • misc build & test framework updates
    • update dependencies
    • update linters
    • update docs deployment branches
    • test forks
    • tidy OS & Python version tests
    • bump primary python version 3.7 => 3.8

@casperdcl casperdcl self-assigned this Sep 9, 2021
@casperdcl casperdcl added this to Next Release in Casper Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #1246 (058fe72) into master (140c948) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1246      +/-   ##
==========================================
- Coverage   89.68%   89.67%   -0.02%     
==========================================
  Files          26       26              
  Lines        1735     1733       -2     
  Branches      287      286       -1     
==========================================
- Hits         1556     1554       -2     
  Misses        133      133              
  Partials       46       46              

@sourcery-ai
Copy link

sourcery-ai bot commented Sep 19, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.18%.

Quality metrics Before After Change
Complexity 11.54 🙂 11.36 🙂 -0.18 👍
Method Length 72.99 🙂 72.84 🙂 -0.15 👍
Working memory 10.18 😞 10.14 😞 -0.04 👍
Quality 60.71% 🙂 60.89% 🙂 0.18% 👍
Other metrics Before After Change
Lines 4287 4238 -49
Changed files Quality Before Quality After Quality Change
.meta/mkdocs.py 58.46% 🙂 58.46% 🙂 0.00%
examples/7zx.py 27.55% 😞 27.52% 😞 -0.03% 👎
tests/tests_contrib.py 75.21% ⭐ 76.14% ⭐ 0.93% 👍
tests/tests_itertools.py 92.92% ⭐ 92.92% ⭐ 0.00%
tests/tests_perf.py 63.52% 🙂 64.30% 🙂 0.78% 👍
tests/tests_tqdm.py 67.21% 🙂 67.29% 🙂 0.08% 👍
tqdm/_monitor.py 75.55% ⭐ 75.55% ⭐ 0.00%
tqdm/_utils.py 79.09% ⭐ 79.09% ⭐ 0.00%
tqdm/rich.py 79.38% ⭐ 79.38% ⭐ 0.00%
tqdm/std.py 47.10% 😞 47.27% 😞 0.17% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
tqdm/std.py tqdm.format_meter 73 ⛔ 572 ⛔ 29 ⛔ 2.09% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
tqdm/std.py tqdm.__init__ 53 ⛔ 553 ⛔ 39 ⛔ 3.16% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
tqdm/std.py tqdm.pandas 53 ⛔ 409 ⛔ 13 😞 15.07% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
examples/7zx.py main 38 ⛔ 379 ⛔ 15 😞 16.33% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
tests/tests_perf.py simple_progress 34 ⛔ 298 ⛔ 17 ⛔ 17.63% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@casperdcl
Copy link
Sponsor Member Author

failing deploy due to snapcore/action-build#25

@casperdcl casperdcl merged commit 18d7aa4 into master Sep 20, 2021
Casper automation moved this from Next Release to Done Sep 20, 2021
@casperdcl
Copy link
Sponsor Member Author

/tag v4.62.3 18d7aa4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Casper
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant