Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing manifest file #8

Open
Munter opened this issue Jan 28, 2019 · 4 comments
Open

Missing manifest file #8

Munter opened this issue Jan 28, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@Munter
Copy link

Munter commented Jan 28, 2019

Since this boilerplate already implements an offline strategy and already tries to improve the mobile display by using touch-icons, tile-images and theme colors, there should really be a web app manifest as part of the setup. https://developer.mozilla.org/en-US/docs/Web/Manifest

@rubenaguadoc
Copy link

Maybe #10 is useful for that.

@tr1s
Copy link
Owner

tr1s commented Jan 28, 2019

@Munter you make a fair point. I went all that way and then stopped at the manifest. Thank you @rubenaguadoc I'll go look into that pull request!

@tr1s tr1s self-assigned this Jan 28, 2019
@tr1s
Copy link
Owner

tr1s commented Jan 29, 2019

I was playing around with it, but after some reading, I think I'm going to opt out of this still. The webpack-pwa-manifest is kind of abandoned, and I don't want to add extra complexity and confusion that might not get resolved in the future.

The idea here was that I'll prepare the boilerplate for people that want to take the full plunge into it themselves.

I'd consider adding in a barebones manifest.json for the sake of it, or if there's a more robust way to inject it that would be nice. I'll look into it more and feel to do the same and let me know your thoughts.

@rubenaguadoc
Copy link

Thank you for that.
Definitely a PWA Manifest is neded to be somehow included.
For me, the proposed package was nice because it handles all the icons and injects itself in the html.
It's true that a barebones json file woud be much more easy and intuitive to configure, but we should figure out how to link it in all the htmls. (Hopefully autimatically, but manually adding one more tag in the head is not that much of a deal).

@tr1s tr1s added the enhancement New feature or request label Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants