Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precision errors running tests #1477

Open
McArthur-Alford opened this issue Mar 15, 2024 · 2 comments
Open

Precision errors running tests #1477

McArthur-Alford opened this issue Mar 15, 2024 · 2 comments
Assignees
Labels
wgpu Related to WGPU backend

Comments

@McArthur-Alford
Copy link

McArthur-Alford commented Mar 15, 2024

Describe the bug
When running the tests, I run into some precision errors. I have ran them a handful of times, and they seem to consistently be the following two tests:

tests::jit::module_nearest_interpolate::tests::test_downsample_interpolation
tests::jit_fusion::module_nearest_interpolate::tests::test_downsample_interpolation

The full log is:

failures:

---- tests::jit::module_nearest_interpolate::tests::test_downsample_interpolation stdout ----
thread 'tests::jit::module_nearest_interpolate::tests::test_downsample_interpolation' panicked at crates/burn-wgpu/src/lib.rs:73:5:
Tensors are not approx eq:
  => Position 3: 7 != 6 | difference 1 > tolerance 0.0010000000000000002
  => Position 9: 161 != 160 | difference 1 > tolerance 0.0010000000000000002
  => Position 15: 315 != 314 | difference 1 > tolerance 0.0010000000000000002
  => Position 21: 469 != 468 | difference 1 > tolerance 0.0010000000000000002

---- tests::jit_fusion::module_nearest_interpolate::tests::test_downsample_interpolation stdout ----
thread 'tests::jit_fusion::module_nearest_interpolate::tests::test_downsample_interpolation' panicked at crates/burn-wgpu/src/lib.rs:73:5:
Tensors are not approx eq:
  => Position 3: 7 != 6 | difference 1 > tolerance 0.0010000000000000002
  => Position 9: 161 != 160 | difference 1 > tolerance 0.0010000000000000002
  => Position 15: 315 != 314 | difference 1 > tolerance 0.0010000000000000002
  => Position 21: 469 != 468 | difference 1 > tolerance 0.0010000000000000002

To Reproduce

  1. Clone the latest version of main
  2. Use run-checks.sh and wait for the errors

Hardware:

  • OS: Linux (NixOS 24.04 with kernel 6.7.6)
  • GPU: AMD ATI Radeon RX 6900 XT
  • CPU: Intel i9-12900k
@WorldSEnder
Copy link
Contributor

As I noted in #1444 I ignored these tests too on my local run. Hardware:

Arch Linux, kernel on 6.7.9
Intel i7-13700K
AMD Radeon RX 5700 XT

@antimora
Copy link
Collaborator

@nathanielsimard since you guys are working on this

@antimora antimora added the wgpu Related to WGPU backend label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wgpu Related to WGPU backend
Projects
None yet
Development

No branches or pull requests

4 participants