feat(marqo): Add marqo instrumentation #1373
Conversation
There was a problem hiding this comment.
Thanks so much for this @Benedikt-Wolf! Left a small comment
|
Hey @nirga, thanks for reviewing my PR! I can't seem to find the comment you mentioned - I'm starting to doubt myself here 😅. Could you confirm if the comment was actually added successfully, or am I just missing something obvious? Thanks! |
| @dont_throw | ||
| def _set_delete_documents_attributes(span, kwargs): | ||
| _set_span_attribute( | ||
| span, "db.marqo.delete_documents.ids_count", count_or_none(kwargs.get("ids")) |
There was a problem hiding this comment.
Can you use the semantic conventions for these? If there are common ones you can use - it'd be best. Otherwise, just extract them to the semantic conventions package.
There was a problem hiding this comment.
With common ones, do you mean using f.e. CHROMADB_DELETE_IDS_COUNT for this example?
There was a problem hiding this comment.
Exactly, but there are already some attributes there with similar meanings from other vector DBs
There was a problem hiding this comment.
I added the new semantic conventions I need to the corresponding file, but I could not use them in the wrapper since it does not import the files from my local changes. I'd do another PR after the opentelemetry-semantic-conventions-ai package is updated changing 'db.marqo.search.query' etc. to AISpanAttributes.MARQO_SEARCH_QUERY to fix that. Or is there another way to resolve this?
There was a problem hiding this comment.
Yes, that's a limitation of Poetry with nested local deps. I've released a version for the semconv so it should work for you now @Benedikt-Wolf
feat(instrumentation): ...orfix(instrumentation): ....Supports the basic operations of adding/deleting documents and querying an index.