Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openai): add support for parallel function calls #1424

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

achang97
Copy link
Contributor

@achang97 achang97 commented Jul 1, 2024

#1427

  • Add support for multiple/parallel tool calls for OpenAI
  • Add ID to function object
  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

Sorry, something went wrong.

@achang97 achang97 changed the title feat(openai): add support for multiple function calls feat(openai): add support for parallel function calls Jul 1, 2024
Copy link
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @achang97! Looks good! Can you take a look at the failing test?

Verified

This commit was signed with the committer’s verified signature.
@achang97 achang97 force-pushed the multiple-function-calls branch from 571de50 to 396bfcd Compare July 1, 2024 20:53
achang97 added 2 commits July 1, 2024 14:15

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
@nirga nirga merged commit ab2ba46 into traceloop:main Jul 2, 2024
8 checks passed
@achang97 achang97 deleted the multiple-function-calls branch July 2, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants