Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wtg: overly broad matches on non-drill/non-gerber files #357

Open
kasbah opened this issue Mar 11, 2021 · 2 comments
Open

wtg: overly broad matches on non-drill/non-gerber files #357

kasbah opened this issue Mar 11, 2021 · 2 comments

Comments

@kasbah
Copy link
Collaborator

kasbah commented Mar 11, 2021

I think due to these really broad matches non-drill files will with fab npth or drill in the filename will get matched as drill.

{match: /fab/, cad: c._CAD_GEDA_PCB},
{match: /npth/, cad: c._CAD_KICAD},
{match: '/drill/', cad: c._CAD_EAGLE_PCBNG},

Noticed it because I'm getting these matches:

    'hardware/teensy-fx-2020-01-12-fab.zip': { type: 'drill', side: 'all' }
    'hardware/teensy-fx-2020-02-10-fab.zip': { type: 'drill', side: 'all' }
@kasbah
Copy link
Collaborator Author

kasbah commented Mar 11, 2021

Also seeing these:

    'drawings.pretty/ruler_panel_bottom.kicad_mod': { type: 'copper', side: 'bottom' },
    'drawings.pretty/ruler_panel_top.kicad_mod': { type: 'copper', side: 'top' },
    'drawings/ruler_panel_bottom.svg': { type: 'copper', side: 'bottom' },
    'drawings/ruler_panel_top.svg': { type: 'copper', side: 'top' },

@kasbah kasbah changed the title wtg: overly broad matches for drill files wtg: overly broad matches on non-drill/non-gerber files Mar 11, 2021
@kasbah
Copy link
Collaborator Author

kasbah commented Feb 6, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant