-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect parsing of Outline #365
Comments
I can get the board to render correctly if I set the gap fill setting to tracespace's board outline parsing is really naive; it only really works if all the individual segments of the outline layer line up. It cannot account for gaps this large with its default settings. |
Thank you for this super quick response. I wonder, does such a high gap fill setting cause other unintended effects? Maybe the default could be increased then. This is a serious issue with the Gerber format in general that it can be sometimes a bid janky. As a team we will think if we can come up with a good proposal of how this could be improved. At least I know what to do when this happens. |
Testing with the new board shape plotter in Gaps:
Full outline plot{
"regions": [
{
"type": "imageRegion",
"segments": [
{
"type": "arc",
"start": [
21.519,
18.517,
0
],
"end": [
21.519,
18.517,
6.283185307179586
],
"center": [
20.573999999999998,
18.517
],
"radius": 0.945
}
]
}
],
"openPaths": [
{
"type": "imagePath",
"width": 0,
"segments": [
{
"type": "arc",
"start": [
28.008,
22.481,
0
],
"end": [
26.989,
23.5,
1.5707963267948966
],
"center": [
26.989,
22.481
],
"radius": 1.019
}
]
},
{
"type": "imagePath",
"width": 0,
"segments": [
{
"type": "line",
"start": [
28.008,
22.481
],
"end": [
28.008,
1.019
]
},
{
"type": "arc",
"start": [
28.008,
1.019,
0
],
"end": [
26.989,
0,
-1.5707963267948966
],
"center": [
26.989,
1.019
],
"radius": 1.019
}
]
},
{
"type": "imagePath",
"width": 0,
"segments": [
{
"type": "arc",
"start": [
24.451,
36.745,
0
],
"end": [
23.451,
37.745,
1.5707963267948966
],
"center": [
23.451,
36.745
],
"radius": 1
},
{
"type": "line",
"start": [
23.451,
37.745
],
"end": [
16.951,
37.745
]
}
]
},
{
"type": "imagePath",
"width": 0,
"segments": [
{
"type": "line",
"start": [
24.451,
36.745
],
"end": [
24.451,
23.5
]
},
{
"type": "line",
"start": [
24.451,
23.5
],
"end": [
26.949,
23.5
]
}
]
},
{
"type": "imagePath",
"width": 0,
"segments": [
{
"type": "arc",
"start": [
0.008,
1.034,
3.141592653589793
],
"end": [
1.042,
0,
4.71238898038469
],
"center": [
1.042,
1.034
],
"radius": 1.034
}
]
},
{
"type": "imagePath",
"width": 0,
"segments": [
{
"type": "line",
"start": [
0.008,
1.034
],
"end": [
0.008,
22.466
]
},
{
"type": "arc",
"start": [
0.008,
22.466,
3.141592653589793
],
"end": [
1.042,
23.5,
1.5707963267948966
],
"center": [
1.042,
22.466
],
"radius": 1.034
},
{
"type": "line",
"start": [
1.042,
23.5
],
"end": [
16.078,
23.5
]
},
{
"type": "line",
"start": [
16.078,
23.5
],
"end": [
16.078,
36.618
]
},
{
"type": "line",
"start": [
16.078,
36.618
],
"end": [
16.078,
36.83
]
}
]
},
{
"type": "imagePath",
"width": 0,
"segments": [
{
"type": "arc",
"start": [
17.09,
37.745,
1.5707963267948966
],
"end": [
16.09,
36.745,
3.141592653589793
],
"center": [
17.09,
36.745
],
"radius": 1
}
]
},
{
"type": "imagePath",
"width": 0,
"segments": [
{
"type": "line",
"start": [
21.133,
0
],
"end": [
27.089,
0
]
}
]
},
{
"type": "imagePath",
"width": 0,
"segments": [
{
"type": "line",
"start": [
21.133,
0
],
"end": [
20.65,
0.483
]
},
{
"type": "line",
"start": [
20.65,
0.483
],
"end": [
10.719,
0.483
]
},
{
"type": "line",
"start": [
10.719,
0.483
],
"end": [
10.236,
0
]
},
{
"type": "line",
"start": [
10.236,
0
],
"end": [
1.1,
0
]
}
]
}
],
"size": [
19.628999999999998,
17.572,
21.519,
19.462
]
} |
This is the outline layer I have
This is what tracespace turns it into
This is the file
buggy.GM1.zip
The text was updated successfully, but these errors were encountered: