Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outline layer is not rendered correctly. #403

Open
shawon1220 opened this issue Jan 12, 2023 · 2 comments
Open

outline layer is not rendered correctly. #403

shawon1220 opened this issue Jan 12, 2023 · 2 comments
Labels
board-shape Issues related to incorrect board shapes bug v5-fixed Ticket is resolved in the `v5` branch

Comments

@shawon1220
Copy link

Hi, this file can't rendering outline layer correctly.

outline file:
gko.zip

tracespace rendering result:
image

correct rendering result:
image

@mcous mcous added the bug label Jan 13, 2023
@mcous
Copy link
Member

mcous commented Jan 13, 2023

Thanks for the report! There appears to be a bug in the v4 outline plotter. I suspect that the problem is here:

var lineSegmentsEqual = function(segment, target) {
return (
segment.type === 'line' &&
((pointsEqual(segment.start, target.start) &&
pointsEqual(segment.end, target.end)) ||
(pointsEqual(segment.start, target.end) &&
pointsEqual(segment.end, target.start)))
)
}

It looks like the condition is missing an && target.type === 'line'

@mcous mcous added help wanted Good issues to tackle if you're looking to contribute v5-fixed Ticket is resolved in the `v5` branch and removed help wanted Good issues to tackle if you're looking to contribute labels Jan 13, 2023
@mcous mcous added the board-shape Issues related to incorrect board shapes label Jan 22, 2023
@kasbah
Copy link
Collaborator

kasbah commented Feb 3, 2023

Should we keep this open since it's still a bug in v4?

@kasbah kasbah reopened this Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board-shape Issues related to incorrect board shapes bug v5-fixed Ticket is resolved in the `v5` branch
Projects
None yet
Development

No branches or pull requests

3 participants