Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bug: Summary mail may contains notifications that should not be in the summary mail #6430

Open
Skylsmoi opened this issue Apr 4, 2024 · 1 comment
Labels
backend issue related to backend developpement /apps bug Issues that had not yet been identified at the time of development delivery. frontend issue related to frontend development / ux / ui / apps to sort need first level analyse and release association

Comments

@Skylsmoi
Copy link
Collaborator

Skylsmoi commented Apr 4, 2024

Tracim version

4.8.0

Issue description

The summary mail received, at most, every day, should contain only unread notifications and mentions from the last 24h.

It sometimes contains notification or mentions that have already been read.

Todo:
Add details about which read notifications can be in the summary mail

How to reproduce

Todo

Screenshots

No response

What browsers are you seeing the problem on?

No response

What devices are you seeing the problem on?

No response

Related PR

No response

@Skylsmoi Skylsmoi added to sort need first level analyse and release association bug Issues that had not yet been identified at the time of development delivery. frontend issue related to frontend development / ux / ui / apps backend issue related to backend developpement /apps labels Apr 4, 2024
@Skylsmoi
Copy link
Collaborator Author

Skylsmoi commented Apr 9, 2024

Update:
It doesn't contains notification already read. But it lacks filtering some notification that are filtered in the notification wall. This makes it looks like it counts read notification.

A beginning of the fix has been made here ed7ce90
It fixes:

  • remove the events where the user is the author
  • remove the mentions because they are counted in the specific mention count
  • remove the entity type WORKSPACE to better match the notification wall. Notification wall actually shows the created spaces but if the space is "on demand", we don't want to count the notif of space we are not part of in the summary mail

@Skylsmoi Skylsmoi added this to Issue to review in Tracim v4.9.0 Apr 9, 2024
@floreal15 floreal15 removed this from Issue to review in Tracim v4.9.0 Apr 25, 2024
@floreal15 floreal15 added this to Issue to review in Tracim v4.10.0 Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend issue related to backend developpement /apps bug Issues that had not yet been identified at the time of development delivery. frontend issue related to frontend development / ux / ui / apps to sort need first level analyse and release association
Projects
Status: Issue to review
Tracim v4.10.0
Issue to review
Development

No branches or pull requests

1 participant