Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules broken after single package install #130

Closed
nriccar opened this issue Jun 8, 2023 · 4 comments
Closed

modules broken after single package install #130

nriccar opened this issue Jun 8, 2023 · 4 comments

Comments

@nriccar
Copy link

nriccar commented Jun 8, 2023

Hey! First of all, great package, thanks for the contribution.

I wanted to know if there's any workaround to prevent modules breaking after a single package install.
Its fine when I run npm i, postinstall gets executed and rn-nodify works.
The problem is when a single package is installed, modules stop working. Any way to fix it?

Thanks!

@mvayngrib
Copy link
Member

hey @nriccar, i see a relevant issue in the npm repo npm/rfcs#325 . Depending on the version of npm you're using, maybe u can use this? https://stackoverflow.com/a/51155609

@nriccar
Copy link
Author

nriccar commented Jun 8, 2023

hey @mvayngrib! I have already reviewed those proposals but npm hooks are discontinued.. sadly I have v8.3.1, and I would like to keep using the latest version..
Any other way of keeping rn-nodify changes even if another package gets installed?

Thanks!

@mvayngrib
Copy link
Member

mvayngrib commented Jun 8, 2023

sorry, not sure how, other than maybe using your own npm scripts instead of npm i some-package, e.g.

"add": "npm i -S $1 && npm run postinstall"

npm run add some-package

@nriccar nriccar closed this as completed Jun 12, 2023
@nriccar
Copy link
Author

nriccar commented Jun 12, 2023

Thank you.. I have a similar solution, but its not 100% what I was looking for. Now I know, rn-nodify has no way of hacking after a single package install! Thank you for the contribution, its a great package :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants