Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expects quoted attributes in HTML unnecessarily, preventing diffing #25

Open
technopagan opened this issue Aug 31, 2020 · 1 comment
Open
Assignees
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@technopagan
Copy link

When trying to diff an HTML file, Graphtage throws an error when encountering e.g.:

<meta name=foo

because it expects quoted attributes like so:

<meta name="foo"

However, the first variant without quotes is perfectly valid HTML and should not prevent Graphtage from diffing the file.

@technopagan technopagan changed the title Throws errors on valid HTML Expects quoted attributes in HTML unnecessarily, preventing diffing Aug 31, 2020
@ESultanik ESultanik added the bug Something isn't working label Sep 3, 2020
@ESultanik ESultanik self-assigned this Sep 3, 2020
@ESultanik ESultanik added enhancement New feature or request good first issue Good for newcomers labels Sep 3, 2020
@ESultanik
Copy link
Collaborator

This is because Graphtage is (incorrectly) currently using Python's XML parser to parse HTML. This is a bug. We need to switch to an actual HTML parser. I will use this issue to track that development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants