Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve function name logging during function tracking #6491

Open
surovic opened this issue Sep 15, 2022 · 0 comments
Open

Improve function name logging during function tracking #6491

surovic opened this issue Sep 15, 2022 · 0 comments
Labels
enhancement New feature or request instrumentation related to the LLVM instrumentation or dfsan integration

Comments

@surovic
Copy link
Collaborator

surovic commented Sep 15, 2022

In the current implementation fast path, each function entry would have to

  1. strlen(function-name)
  2. acquire lock
  3. lookup function name map (compute hash)
  4. return index

Couldn't all this information be known at compile time? I don't think we should change the current approach, but rather think about if we should do a follow up PR that tries to shift as much work as possible to compile time.

Originally posted by @hbrodin in #6473 (comment)

@surovic surovic added enhancement New feature or request instrumentation related to the LLVM instrumentation or dfsan integration labels Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request instrumentation related to the LLVM instrumentation or dfsan integration
Projects
None yet
Development

No branches or pull requests

1 participant