Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should /lib be checked into git? #42

Open
tgriesser opened this issue Apr 10, 2015 · 4 comments
Open

Should /lib be checked into git? #42

tgriesser opened this issue Apr 10, 2015 · 4 comments

Comments

@tgriesser
Copy link
Member

The age old question of whether compiled files should only be regen on release. If you're looking to support the absolute paths to files rather than name-spacing on a single build then I'd guess you may need to - unless you only check in at release time?

Makes PR's a bit of a pain to manage though

@kevinbeaty
Copy link
Member

Yeah. I can't decide on this one. I think we do want to generate the browser files in build on release. Not sure about lib as those are there mostly for npm (and will be published there appropriately).

I could go either way.

@tgriesser
Copy link
Member Author

The only real benefit of keeping things checked in is that you can reference any particular SHA commit in git in your package.json and it'll "just work", but this isn't a real issue if releases are cut frequently.

@kevinbeaty
Copy link
Member

I'm leaning towards keeping it out for now, unless you have strong feelings about including them.. I'd like to avoid the downside you mentioned of making merge conflicts more difficult than necessary as they would need to be resolved in both places. Hopefully it won't be too common that someone would want to pin to a specific commit.

@tgriesser
Copy link
Member Author

Cool - I think once you sign off on the other LazyIterator patch I'd be 👍 on a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants