-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should /lib be checked into git? #42
Comments
Yeah. I can't decide on this one. I think we do want to generate the browser files in I could go either way. |
The only real benefit of keeping things checked in is that you can reference any particular SHA commit in git in your package.json and it'll "just work", but this isn't a real issue if releases are cut frequently. |
I'm leaning towards keeping it out for now, unless you have strong feelings about including them.. I'd like to avoid the downside you mentioned of making merge conflicts more difficult than necessary as they would need to be resolved in both places. Hopefully it won't be too common that someone would want to pin to a specific commit. |
Cool - I think once you sign off on the other LazyIterator patch I'd be 👍 on a new release. |
The age old question of whether compiled files should only be regen on release. If you're looking to support the absolute paths to files rather than name-spacing on a single build then I'd guess you may need to - unless you only check in at release time?
Makes PR's a bit of a pain to manage though
The text was updated successfully, but these errors were encountered: