Defer saving new message until got response from openAI #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
189
changed the title
src/chatgpt-api.ts
Outdated
| @@ -287,7 +288,9 @@ export class ChatGPTAPI { | |||
| } | |||
| } | |||
| ).then((message) => { | |||
| return this._upsertMessage(message).then(() => message) | |||
| return this._upsertMessage(latestQuestion).then(() => | |||
There was a problem hiding this comment.
will change to upsert these in parallel
transitive-bullshit
approved these changes
Apr 2, 2023
transitive-bullshit
merged commit 9bb7da3
into
transitive-bullshit:main
1 of 2 checks passed
2 tasks
mi-ann0613
pushed a commit
to mi-ann0613/chatgpt-api
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defer saving new message until got response from openAI. It only can be save together with openAI's response, both save or both not. That make database clean, be non-redundancy
See the issue