Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed broken link #3166

Merged
merged 1 commit into from Oct 6, 2021
Merged

removed broken link #3166

merged 1 commit into from Oct 6, 2021

Conversation

YukeshShr
Copy link
Contributor

https://app.intercom.com/a/apps/qiqpfgjg/inbox/inbox/all/conversations/26852700005169
No. 7i, could not find a replacement link so removed the broken link.

https://app.intercom.com/a/apps/qiqpfgjg/inbox/inbox/all/conversations/26852700005169
No. 7i, could not find a replacement link so removed the broken link.
@Murderlon
Copy link
Member

Not sure why these tests keep failing here

@aduh95
Copy link
Member

aduh95 commented Oct 6, 2021

AFAICT, http://hughsk.io/disc/ is not a broken link (at least I'm able to access it). What we should do would be to use https: protocol (https://hughsk.io/disc/) or a protocol relative URL (//hughsk.io/disc/).

@Murderlon Murderlon merged commit 44ea88a into transloadit:main Oct 6, 2021
aduh95 added a commit to aduh95/uppy that referenced this pull request Oct 6, 2021
The link doesn't look broken to me.

This reverts commit 44ea88a.
arturi pushed a commit that referenced this pull request Oct 7, 2021
The link doesn't look broken to me.

This reverts commit 44ea88a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants