Default allow headers #3167
Merged
Default allow headers #3167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the following headers to access-control-allow-headers by default: Authorization, Origin, Content-Type, Accept They are needed for basic operation. See #3021 therefore also remove custom middlewares in examples and standalone
AWS now requires JSON instead of XML format
mifi
added
Companion
aduh95
reviewed
Sep 3, 2021
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
Sep 4, 2021
Murderlon
approved these changes
Sep 6, 2021
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
* refactor cors middleware to avoid duplicates * Make more ACAH headers default Add the following headers to access-control-allow-headers by default: Authorization, Origin, Content-Type, Accept They are needed for basic operation. See transloadit#3021 therefore also remove custom middlewares in examples and standalone * Update outdated readme for S3 AWS now requires JSON instead of XML format * Update packages/@uppy/companion/src/server/middlewares.js Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> * Update packages/@uppy/companion/src/server/middlewares.js Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> * fix review comments Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following headers to
access-control-allow-headersby default:I believe they are always needed for basic operation of companion, and if the developers forget to add them I believe they will get cryptic errors. See aws-s3-multipsart upload issue #3021
Let me know if anyone knows any reason why these headers cannot be default added.
Also:
setHeaderin examples and standaloneIf this PR can not be merged, we need to update all example code to include the custom
setHeadermiddleware.