Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make uploadUrls recommended #3182

Merged
merged 4 commits into from Sep 30, 2021
Merged

Make uploadUrls recommended #3182

merged 4 commits into from Sep 30, 2021
+51 −19

Conversation

mifi
Copy link
Contributor

@mifi mifi commented Sep 9, 2021

  • warn on startup if uploadUrls is not specified as not specifying it is a security risk
  • improve docs to make it more clear why uploadUrls should be specified (say that uploadUrls is required even though it is not, due to backward compatibility)
  • no longer require_tld (it gives a false security and causes problems when wanting to use localhost) - fixes unable to set companion to the localhost while running in container. #2831

@mifi
Make uploadUrls recommended
f570748 
- warn on startup if uploadUrls is not specified as not specifying it is a security risk
- improve docs to make it more clear why uploadUrls should be specified (say that uploadUrls is required even though it is not, due to backward compatibility)
- no longer require_tld (it gives a false security) - fixes #2831
@mifi mifi mentioned this pull request Sep 9, 2021
Closed
6 tasks
@aduh95
Copy link
Member

aduh95 commented Sep 9, 2021

Should we s/whitelist/allowlist/?

@mifi
Copy link
Contributor Author

mifi commented Sep 9, 2021

I don't think I heard the word allowlist before but if some people find whitelist racist, then why not

mifi
mifi commented Sep 9, 2021
View reviewed changes
packages/@uppy/companion/src/companion.js Outdated Show resolved Hide resolved
packages/@uppy/companion/test/__tests__/uploader.js Outdated Show resolved Hide resolved
packages/@uppy/companion/test/__tests__/uploader.js Outdated Show resolved Hide resolved
packages/@uppy/companion/test/__tests__/uploader.js Outdated Show resolved Hide resolved
website/src/docs/companion.md Outdated Show resolved Hide resolved
mifi
mifi commented Sep 10, 2021
View reviewed changes
website/src/docs/companion.md Outdated Show resolved Hide resolved
mifi and others added 2 commits September 10, 2021 17:54
@mifi @aduh95
Apply suggestions from code review
85aec7c 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@mifi
remove example: []
157f6c2
@mifi mifi merged commit 1ae19a2 into main Sep 30, 2021
@mifi mifi deleted the recommend-uploadurls branch September 30, 2021 09:31
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
@mifi @aduh95
Make uploadUrls recommended (transloadit#3182)
d08d377 
* Make uploadUrls recommended

- warn on startup if uploadUrls is not specified as not specifying it is a security risk
- improve docs to make it more clear why uploadUrls should be specified (say that uploadUrls is required even though it is not, due to backward compatibility)
- no longer require_tld (it gives a false security) - fixes transloadit#2831

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

* remove `example: []`

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvz kvz kvz left review comments

@Murderlon Murderlon Murderlon approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unable to set companion to the localhost while running in container.
4 participants
@mifi @aduh95 @kvz @Murderlon