Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include status code in HTTP error message #3212

Merged
merged 1 commit into from Sep 30, 2021
Merged

Conversation

mifi
Copy link
Contributor

@mifi mifi commented Sep 21, 2021

Makes it easier to debug when we can see it in the log files

e.g.:

companion: 2021-09-20T20:03:53.226Z [error] provider.onedrive.list.error ProviderApiError: Access Denied
companion: 2021-09-20T19:57:49.897Z [error] provider.onedrive.list.error ProviderApiError: Item does not exist

We don't know what is the error code here...

Makes it easier to debug when we can see it in the log files

e.g.
```
companion: 2021-09-20T20:03:53.226Z [error] provider.onedrive.list.error ProviderApiError: Access Denied
companion: 2021-09-20T19:57:49.897Z [error] provider.onedrive.list.error ProviderApiError: Item does not exist
```
We don't know what is the error code here...
@mifi mifi merged commit f341c0f into main Sep 30, 2021
@mifi mifi deleted the aroviderapierror-statuscode branch September 30, 2021 09:59
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
Makes it easier to debug when we can see it in the log files

e.g.
```
companion: 2021-09-20T20:03:53.226Z [error] provider.onedrive.list.error ProviderApiError: Access Denied
companion: 2021-09-20T19:57:49.897Z [error] provider.onedrive.list.error ProviderApiError: Item does not exist
```
We don't know what is the error code here...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants