Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/image-editor: add workaround for when Cropper is loaded as ESM #3218

Merged
merged 3 commits into from Sep 28, 2021

Conversation

aduh95
Copy link
Member

@aduh95 aduh95 commented Sep 21, 2021

A silly hack that we can get rid of when moving to ESM.

Fixes: #3199

@kvz
Copy link
Member

kvz commented Sep 23, 2021

When are we moving to ESM? If that is planned for 3.0, let's create a ## 3.0 milestone in our BACKLOG.md and bundle the todo of:

- [ ] @uppy/image-editor: Remove silly hack to work around non-ESM

along with this PR

aduh95 and others added 2 commits September 23, 2021 11:01
Co-authored-by: Kevin van Zonneveld <kevin@vanzonneveld.net>
@aduh95 aduh95 merged commit 46b0540 into main Sep 28, 2021
@aduh95 aduh95 deleted the fix-cropper-not-constructor branch September 28, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image-Editor in Vue.js (Vue 3.x): TypeError: Cropper2 is not a constructor
3 participants