Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/transloadit: pass fields to transloadit #3228

Merged
merged 2 commits into from Oct 6, 2021
Merged

Conversation

aduh95
Copy link
Member

@aduh95 aduh95 commented Sep 28, 2021

Co-authored-by: Merlijn Vos Murderlon@users.noreply.github.com
Fixes: #3189

Co-authored-by: Merlijn Vos <Murderlon@users.noreply.github.com>
Fixes: #3189
Copy link
Member

@Murderlon Murderlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the E2E tests works correctly then we can merge

@aduh95
Copy link
Member Author

aduh95 commented Oct 5, 2021

If the E2E tests works correctly then we can merge

It doesn't though, and I don't know if we should block the landing at this point as I don't know how to make them work.

@aduh95
Copy link
Member Author

aduh95 commented Oct 5, 2021

The clue I have is this is skipping the test:

const transloaditKey = process.env.TRANSLOADIT_KEY
if (transloaditKey === undefined) {
console.log('skipping Transloadit integration test')
return this.skip()
}

If someone knows if and why TRANSLOADIT_KEY is not defined, and how to fix it, I'm happy to work on it, but otherwise we can leave it to a future PR to fix this test suite.

@aduh95 aduh95 merged commit 8fbabe4 into main Oct 6, 2021
@aduh95 aduh95 deleted the transloadit-fields-fix branch October 6, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uppy version 2.1.0 does not pass fields to TransloadIT
2 participants