Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about include in the Dashboard #3236

Merged
merged 1 commit into from Oct 5, 2021
Merged

Conversation

epexa
Copy link
Contributor

@epexa epexa commented Oct 1, 2021

No description provided.

Copy link
Member

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is also included in @uppy/angular, @uppy/svelte, @uppy/react, @uppy/robodog, and @uppy/vue. The list can be found on the Dependents tab of https://www.npmjs.com/package/@uppy/status-bar.

Why do you think it's necessary to add this info in the StatusBar docs? Shouldn't it be in the Dashboard one instead?

@arturi
Copy link
Contributor

arturi commented Oct 2, 2021

@aduh95 this is about StatusBar actually being used by the Dashboard, meaning you don't need to .use it manually. Not about npm dependencies. So it makes sense to mention this for Informer and Statusbar.

@arturi arturi merged commit 6becd11 into transloadit:main Oct 5, 2021
@arturi
Copy link
Contributor

arturi commented Oct 5, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants