Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Multipart: Paused uploads hang indefinitely on resume #3341

Closed
yaegor opened this issue Dec 2, 2021 · 1 comment · Fixed by #3342
Closed

S3 Multipart: Paused uploads hang indefinitely on resume #3341

yaegor opened this issue Dec 2, 2021 · 1 comment · Fixed by #3342
Labels

Comments

@yaegor
Copy link
Contributor

yaegor commented Dec 2, 2021

When @uppy/aws-s3-multipart is used:

  • start upload
  • pause upload while some parts are being uploaded
  • resume upload
    the parts are listed from the server and then the upload hangs in the "uploading" state and never continues, no attempts to re-upload missing parts are made.
    This is a regression, most probbaly brought in by uppy 2.0.0
@yaegor
Copy link
Contributor Author

yaegor commented Dec 3, 2021

I've looked into the code more and lockedCandidatesForBatch cannot be just dropped as in #3342 as that can result in duplicate parts uploads. Seems like chunk's busy state can be set to true before preparing chunk for upload and since busy state is properly reset on upload errors, that should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant