Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: drop stringify-object dependency to generate locales #3344

Merged
merged 2 commits into from Dec 8, 2021

Conversation

aduh95
Copy link
Member

@aduh95 aduh95 commented Dec 3, 2021

We can use JSON.stringify and rely on ESLint auto-fixing.

Copy link
Member

@Murderlon Murderlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also nice that you fixed some broken links. Since you edited the webcam doc file, could you check if these now also work?

Capture d’écran 2021-12-06 à 10 31 45

We can use `JSON.stringify` and rely on ESLint auto-fixing.
@aduh95
Copy link
Member Author

aduh95 commented Dec 6, 2021

Since you edited the webcam doc file, could you check if these now also work?

Moved it to a separate PR: #3346

@aduh95 aduh95 merged commit 12e2fab into transloadit:main Dec 8, 2021
@aduh95 aduh95 deleted the no-more-stringify-object branch December 8, 2021 12:25
@github-actions github-actions bot mentioned this pull request Dec 9, 2021
github-actions bot added a commit that referenced this pull request Dec 9, 2021
| Package           | Version | Package           | Version |
| ----------------- | ------- | ----------------- | ------- |
| @uppy/angular     |   0.2.7 | @uppy/store-redux |   2.0.3 |
| @uppy/audio       |   0.2.1 | @uppy/svelte      |   1.0.6 |
| @uppy/aws-s3      |   2.0.7 | @uppy/vue         |   0.4.4 |
| @uppy/companion   |   3.1.3 | @uppy/xhr-upload  |   2.0.7 |
| @uppy/core        |   2.1.4 | @uppy/robodog     |   2.1.5 |
| @uppy/dashboard   |   2.1.3 | uppy              |   2.3.1 |
| @uppy/locales     |   2.0.5 |                   |         |

- meta: update npm deps (Antoine du Hamel / #3352)
- @uppy/companion: fix Dockerfile and deploy automation (Mikael Finstad / #3355)
- @uppy/companion: don’t pin Yarn version in `package.json` (Antoine du Hamel / #3347)
- @uppy/aws-s3,@uppy/core,@uppy/dashboard,@uppy/store-redux,@uppy/xhr-upload: deps: use `nanoid/non-secure` to workaround react-native limitation (Antoine du Hamel / #3350)
- @uppy/audio: showRecordingLength option was removed, always clearInterval (Artur Paikin / #3351)
- meta: drop `stringify-object` dependency to generate locales (Antoine du Hamel / #3344)
- meta: add release automations (Antoine du Hamel / #3304)
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
| Package           | Version | Package           | Version |
| ----------------- | ------- | ----------------- | ------- |
| @uppy/angular     |   0.2.7 | @uppy/store-redux |   2.0.3 |
| @uppy/audio       |   0.2.1 | @uppy/svelte      |   1.0.6 |
| @uppy/aws-s3      |   2.0.7 | @uppy/vue         |   0.4.4 |
| @uppy/companion   |   3.1.3 | @uppy/xhr-upload  |   2.0.7 |
| @uppy/core        |   2.1.4 | @uppy/robodog     |   2.1.5 |
| @uppy/dashboard   |   2.1.3 | uppy              |   2.3.1 |
| @uppy/locales     |   2.0.5 |                   |         |

- meta: update npm deps (Antoine du Hamel / transloadit#3352)
- @uppy/companion: fix Dockerfile and deploy automation (Mikael Finstad / transloadit#3355)
- @uppy/companion: don’t pin Yarn version in `package.json` (Antoine du Hamel / transloadit#3347)
- @uppy/aws-s3,@uppy/core,@uppy/dashboard,@uppy/store-redux,@uppy/xhr-upload: deps: use `nanoid/non-secure` to workaround react-native limitation (Antoine du Hamel / transloadit#3350)
- @uppy/audio: showRecordingLength option was removed, always clearInterval (Artur Paikin / transloadit#3351)
- meta: drop `stringify-object` dependency to generate locales (Antoine du Hamel / transloadit#3344)
- meta: add release automations (Antoine du Hamel / transloadit#3304)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants