New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: drop stringify-object
dependency to generate locales
#3344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Murderlon
reviewed
Dec 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use `JSON.stringify` and rely on ESLint auto-fixing.
aduh95
force-pushed
the
no-more-stringify-object
branch
from
December 6, 2021 23:29
6460a54
to
d118970
Compare
Moved it to a separate PR: #3346 |
Murderlon
approved these changes
Dec 7, 2021
Merged
github-actions bot
added a commit
that referenced
this pull request
Dec 9, 2021
| Package | Version | Package | Version | | ----------------- | ------- | ----------------- | ------- | | @uppy/angular | 0.2.7 | @uppy/store-redux | 2.0.3 | | @uppy/audio | 0.2.1 | @uppy/svelte | 1.0.6 | | @uppy/aws-s3 | 2.0.7 | @uppy/vue | 0.4.4 | | @uppy/companion | 3.1.3 | @uppy/xhr-upload | 2.0.7 | | @uppy/core | 2.1.4 | @uppy/robodog | 2.1.5 | | @uppy/dashboard | 2.1.3 | uppy | 2.3.1 | | @uppy/locales | 2.0.5 | | | - meta: update npm deps (Antoine du Hamel / #3352) - @uppy/companion: fix Dockerfile and deploy automation (Mikael Finstad / #3355) - @uppy/companion: don’t pin Yarn version in `package.json` (Antoine du Hamel / #3347) - @uppy/aws-s3,@uppy/core,@uppy/dashboard,@uppy/store-redux,@uppy/xhr-upload: deps: use `nanoid/non-secure` to workaround react-native limitation (Antoine du Hamel / #3350) - @uppy/audio: showRecordingLength option was removed, always clearInterval (Artur Paikin / #3351) - meta: drop `stringify-object` dependency to generate locales (Antoine du Hamel / #3344) - meta: add release automations (Antoine du Hamel / #3304)
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
| Package | Version | Package | Version | | ----------------- | ------- | ----------------- | ------- | | @uppy/angular | 0.2.7 | @uppy/store-redux | 2.0.3 | | @uppy/audio | 0.2.1 | @uppy/svelte | 1.0.6 | | @uppy/aws-s3 | 2.0.7 | @uppy/vue | 0.4.4 | | @uppy/companion | 3.1.3 | @uppy/xhr-upload | 2.0.7 | | @uppy/core | 2.1.4 | @uppy/robodog | 2.1.5 | | @uppy/dashboard | 2.1.3 | uppy | 2.3.1 | | @uppy/locales | 2.0.5 | | | - meta: update npm deps (Antoine du Hamel / transloadit#3352) - @uppy/companion: fix Dockerfile and deploy automation (Mikael Finstad / transloadit#3355) - @uppy/companion: don’t pin Yarn version in `package.json` (Antoine du Hamel / transloadit#3347) - @uppy/aws-s3,@uppy/core,@uppy/dashboard,@uppy/store-redux,@uppy/xhr-upload: deps: use `nanoid/non-secure` to workaround react-native limitation (Antoine du Hamel / transloadit#3350) - @uppy/audio: showRecordingLength option was removed, always clearInterval (Artur Paikin / transloadit#3351) - meta: drop `stringify-object` dependency to generate locales (Antoine du Hamel / transloadit#3344) - meta: add release automations (Antoine du Hamel / transloadit#3304)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use
JSON.stringify
and rely on ESLint auto-fixing.