Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: move dev workspace to private/ #3368

Merged
merged 3 commits into from Dec 14, 2021

Conversation

aduh95
Copy link
Member

@aduh95 aduh95 commented Dec 13, 2021

I've also decided to prefix all private packages with @uppy-dev/ for consistency (could help if we need to do something like yarn workspaces --include '@uppy-dev/*' foreach …). wdyt?

Copy link
Member

@Murderlon Murderlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have a strong opinion on the @uppy-dev prefix but looks good.

Eventually (pretty soon) I imagine we will have multiple dev environments, at least for drag-drop, but I would also be good to have one for angular, vue, and react to work on those easily. How will we do that? dev:dashboard, dev:drag-drop, dev:cra (create-react-app), etc? Or something else?

@aduh95
Copy link
Member Author

aduh95 commented Dec 13, 2021

I don't think adding multiple subpackages would scale. In case you are not aware, drag-drop is already integrated:

switch (window.location.pathname.toLowerCase()) {
case '/':
case '/dashboard.html': Dashboard(); break
case '/dragdrop.html': DragDrop(); break
}

@aduh95 aduh95 merged commit b0bf1a3 into transloadit:main Dec 14, 2021
@aduh95 aduh95 deleted the move-dev-to-private branch December 14, 2021 11:53
@github-actions github-actions bot mentioned this pull request Dec 21, 2021
github-actions bot added a commit that referenced this pull request Dec 21, 2021
| Package         | Version | Package         | Version |
| --------------- | ------- | --------------- | ------- |
| @uppy/angular   |   0.2.8 | @uppy/vue       |   0.4.5 |
| @uppy/companion |   3.1.4 | uppy            |   2.3.2 |
| @uppy/svelte    |   1.0.7 |                 |         |

- meta: fix release script (Antoine du Hamel)
- @uppy/core: document file.name (Merlijn Vos / #3381)
- @uppy/angular,@uppy/companion,@uppy/svelte,@uppy/vue: add `.npmignore` files to ignore `.gitignore` when packing (Antoine du Hamel / #3380)
- meta: add VSCode workspace settings to `.gitignore` (Antoine du Hamel)
- @uppy/companion: Upgrade ws in companion (Merlijn Vos / #3377)
- meta: use ESBuild to bundle in E2E test suite (Antoine du Hamel / #3375)
- meta: update linter config to parse ESM files (Antoine du Hamel / #3371)
- meta: move dev workspace to `private/` (Antoine du Hamel / #3368)
- meta: use Vite for examples/dev (Antoine du Hamel / #3361)
- website: remove dependency on `crypto` in @uppy/transloadit example (Antoine du Hamel / #3367)
- meta: enable linter on website examples (Antoine du Hamel / #3366)
- meta: enable linter on mjs scripts (Antoine du Hamel / #3364)
- @uppy/angular: Fix module field in `package.json` (Merlijn Vos / #3365)
- meta: improve release script wording and formatting (Artur Paikin)
Murderlon added a commit that referenced this pull request Jan 12, 2022
* main: (45 commits)
  Polished the latest update blog (#3390)
  docs: fix typo in audio.md (#3389)
  website: 2.0-2.3 post draft (#3370)
  Release: uppy@2.3.2 (#3383)
  meta: fix release script
  @uppy/core: document file.name (#3381)
  add `.npmignore` files to ignore .gitignore when packing (#3380)
  meta: add VSCode workspace settings to `.gitignore`
  Upgrade ws in companion (#3377)
  meta: use ESBuild to bundle in E2E test suite (#3375)
  meta: update linter config to parse ESM files (#3371)
  meta: move dev workspace to `private/` (#3368)
  meta: use Vite for examples/dev (#3361)
  website: remove dependency on `crypto` in @uppy/transloadit example (#3367)
  tools: enable linter on website examples (#3366)
  meta: enable linter on mjs scripts (#3364)
  Fix module field in @uppy/angular package.json (#3365)
  Release: uppy@2.3.1 (#3357)
  meta: improve release script wording and formatting
  meta: update npm deps (#3352)
  ...
vymao pushed a commit to vymao/uppy that referenced this pull request Mar 29, 2022
* main: (45 commits)
  Polished the latest update blog (transloadit#3390)
  docs: fix typo in audio.md (transloadit#3389)
  website: 2.0-2.3 post draft (transloadit#3370)
  Release: uppy@2.3.2 (transloadit#3383)
  meta: fix release script
  @uppy/core: document file.name (transloadit#3381)
  add `.npmignore` files to ignore .gitignore when packing (transloadit#3380)
  meta: add VSCode workspace settings to `.gitignore`
  Upgrade ws in companion (transloadit#3377)
  meta: use ESBuild to bundle in E2E test suite (transloadit#3375)
  meta: update linter config to parse ESM files (transloadit#3371)
  meta: move dev workspace to `private/` (transloadit#3368)
  meta: use Vite for examples/dev (transloadit#3361)
  website: remove dependency on `crypto` in @uppy/transloadit example (transloadit#3367)
  tools: enable linter on website examples (transloadit#3366)
  meta: enable linter on mjs scripts (transloadit#3364)
  Fix module field in @uppy/angular package.json (transloadit#3365)
  Release: uppy@2.3.1 (transloadit#3357)
  meta: improve release script wording and formatting
  meta: update npm deps (transloadit#3352)
  ...
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
| Package         | Version | Package         | Version |
| --------------- | ------- | --------------- | ------- |
| @uppy/angular   |   0.2.8 | @uppy/vue       |   0.4.5 |
| @uppy/companion |   3.1.4 | uppy            |   2.3.2 |
| @uppy/svelte    |   1.0.7 |                 |         |

- meta: fix release script (Antoine du Hamel)
- @uppy/core: document file.name (Merlijn Vos / transloadit#3381)
- @uppy/angular,@uppy/companion,@uppy/svelte,@uppy/vue: add `.npmignore` files to ignore `.gitignore` when packing (Antoine du Hamel / transloadit#3380)
- meta: add VSCode workspace settings to `.gitignore` (Antoine du Hamel)
- @uppy/companion: Upgrade ws in companion (Merlijn Vos / transloadit#3377)
- meta: use ESBuild to bundle in E2E test suite (Antoine du Hamel / transloadit#3375)
- meta: update linter config to parse ESM files (Antoine du Hamel / transloadit#3371)
- meta: move dev workspace to `private/` (Antoine du Hamel / transloadit#3368)
- meta: use Vite for examples/dev (Antoine du Hamel / transloadit#3361)
- website: remove dependency on `crypto` in @uppy/transloadit example (Antoine du Hamel / transloadit#3367)
- meta: enable linter on website examples (Antoine du Hamel / transloadit#3366)
- meta: enable linter on mjs scripts (Antoine du Hamel / transloadit#3364)
- @uppy/angular: Fix module field in `package.json` (Merlijn Vos / transloadit#3365)
- meta: improve release script wording and formatting (Artur Paikin)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants