Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use semver as tag on Docker Hub for Companion #3655

Closed
maltesa opened this issue Apr 20, 2022 · 4 comments
Closed

Use semver as tag on Docker Hub for Companion #3655

maltesa opened this issue Apr 20, 2022 · 4 comments
Labels
Companion The auth server (for Instagram, GDrive, etc) and upload proxy (for S3) Feature

Comments

@maltesa
Copy link

maltesa commented Apr 20, 2022

I would like to use docker to deploy the latest stable companion. E.g., assuming 3.5.0 is the latest companion version: transloadit/companion:3.5.0 or transloadit/companion:v3.5.0.

But I can not find any images on dockerhub that are tagged with a semantic version. Assuming that the image tagged with latest stable image, I ran into some problems with the companion not working as expected, as the latest image is build from the latest commit on the main branch (if I'm correct). I found this pull request (https://github.com/transloadit/uppy/pull/2771/files) that looks like it added proper tags, but they are not pushed to dockerhub.
@Murderlon
Copy link
Member

Murderlon commented Apr 20, 2022 •
edited

Indeed we always publish companion to docker hub on any companion change. But it is not done per release.

cc @arturi @mifi

@Murderlon
Copy link
Member

Closing this to keep the issue count maintainable. Feel free to continue the discussion here.

@Murderlon Murderlon closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2022
@jdcalvin
Copy link

@Murderlon given this recent PR #4037 is there any interest in reconsidering this?

@Murderlon Murderlon added Feature Companion The auth server (for Instagram, GDrive, etc) and upload proxy (for S3) and removed Question 💬 Discussion labels Aug 30, 2022
@Murderlon Murderlon reopened this Aug 30, 2022
@Murderlon Murderlon changed the title Docker Hub Version Tags Use semver as tag on Docker Hub for Companion Aug 30, 2022
@Murderlon Murderlon mentioned this issue Aug 31, 2022
Closed
@aduh95
Copy link
Member

aduh95 commented Sep 25, 2022

Hello, this is done: https://hub.docker.com/r/transloadit/companion/tags

Let us know if you think we can still improve our release process, or if you see something else missing.

@aduh95 aduh95 closed this as completed Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Companion The auth server (for Instagram, GDrive, etc) and upload proxy (for S3) Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Companion deploy workflow & use semver as tag transloadit/uppy
4 participants
@maltesa @jdcalvin @Murderlon @aduh95