meta: disable ESM to CJS transform in dist files #3773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
changed the title
If we are doing all hacks in this PR, we shouldn't forget these:
|
|
|
Seems this breaks the React e2e tests somehow? |
aduh95
force-pushed
the
3.x
branch
3 times, most recently
from
6f42104
to
b37fc15
Compare
I forgot the React package wasn't ESM yet (it has to be a breaking change): |
This commit removes all the hacks that needed to happen in order to ship working CJS code. Onwards, we plan to distribute Uppy packages as ESM.
arturi
approved these changes
May 30, 2022
aduh95
added a commit
that referenced
this pull request
May 30, 2022
* meta: disable ESM to CJS transorm in dist files This commit removes all the hacks that needed to happen in order to ship working CJS code. Onwards, we plan to distribute Uppy packages as ESM. * No mocking with Jest and ESM
aduh95
added a commit
that referenced
this pull request
May 30, 2022
* meta: disable ESM to CJS transorm in dist files This commit removes all the hacks that needed to happen in order to ship working CJS code. Onwards, we plan to distribute Uppy packages as ESM. * No mocking with Jest and ESM
github-actions bot
added a commit
that referenced
this pull request
May 30, 2022
| Package | Version | Package | Version | | ------------------------- | ---------- | ------------------------- | ---------- | | @uppy/audio | 3.0.0-beta | @uppy/progress-bar | 3.0.0-beta | | @uppy/aws-s3 | 3.0.0-beta | @uppy/provider-views | 3.0.0-beta | | @uppy/aws-s3-multipart | 3.0.0-beta | @uppy/react | 3.0.0-beta | | @uppy/box | 3.0.0-beta | @uppy/redux-dev-tools | 3.0.0-beta | | @uppy/companion | 4.0.0-beta | @uppy/robodog | 3.0.0-beta | | @uppy/companion-client | 3.0.0-beta | @uppy/screen-capture | 3.0.0-beta | | @uppy/compressor | 3.0.0-beta | @uppy/status-bar | 3.0.0-beta | | @uppy/core | 3.0.0-beta | @uppy/store-default | 3.0.0-beta | | @uppy/dashboard | 3.0.0-beta | @uppy/store-redux | 3.0.0-beta | | @uppy/drag-drop | 3.0.0-beta | @uppy/svelte | 3.0.0-beta | | @uppy/drop-target | 3.0.0-beta | @uppy/thumbnail-generator | 3.0.0-beta | | @uppy/dropbox | 3.0.0-beta | @uppy/transloadit | 3.0.0-beta | | @uppy/facebook | 3.0.0-beta | @uppy/tus | 3.0.0-beta | | @uppy/file-input | 3.0.0-beta | @uppy/unsplash | 3.0.0-beta | | @uppy/form | 3.0.0-beta | @uppy/url | 3.0.0-beta | | @uppy/golden-retriever | 3.0.0-beta | @uppy/utils | 5.0.0-beta | | @uppy/google-drive | 3.0.0-beta | @uppy/vue | 3.0.0-beta | | @uppy/image-editor | 3.0.0-beta | @uppy/webcam | 3.0.0-beta | | @uppy/informer | 3.0.0-beta | @uppy/xhr-upload | 3.0.0-beta | | @uppy/instagram | 3.0.0-beta | @uppy/zoom | 3.0.0-beta | | @uppy/locales | 3.0.0-beta | uppy | 3.0.0-beta | | @uppy/onedrive | 3.0.0-beta | | | - meta: temporary adjust release script for the beta (Antoine du Hamel) - meta: disable ESM to CJS transform in dist files (Antoine du Hamel / #3773) - @uppy/companion: remove `searchProviders` wrapper & move `s3` options (Merlijn Vos / #3781) - meta: do not test on EOL versions of Node.js (Antoine du Hamel / #3786) - @uppy/companion: remove support for EOL versions of Node.js (Antoine du Hamel / #3784) - @uppy/react: refactor to ESM (Antoine du Hamel / #3780) - @uppy/transloadit: remove IE 10 hack (Antoine du Hamel / #3777)
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
| Package | Version | Package | Version | | ------------------------- | ---------- | ------------------------- | ---------- | | @uppy/audio | 3.0.0-beta | @uppy/progress-bar | 3.0.0-beta | | @uppy/aws-s3 | 3.0.0-beta | @uppy/provider-views | 3.0.0-beta | | @uppy/aws-s3-multipart | 3.0.0-beta | @uppy/react | 3.0.0-beta | | @uppy/box | 3.0.0-beta | @uppy/redux-dev-tools | 3.0.0-beta | | @uppy/companion | 4.0.0-beta | @uppy/robodog | 3.0.0-beta | | @uppy/companion-client | 3.0.0-beta | @uppy/screen-capture | 3.0.0-beta | | @uppy/compressor | 3.0.0-beta | @uppy/status-bar | 3.0.0-beta | | @uppy/core | 3.0.0-beta | @uppy/store-default | 3.0.0-beta | | @uppy/dashboard | 3.0.0-beta | @uppy/store-redux | 3.0.0-beta | | @uppy/drag-drop | 3.0.0-beta | @uppy/svelte | 3.0.0-beta | | @uppy/drop-target | 3.0.0-beta | @uppy/thumbnail-generator | 3.0.0-beta | | @uppy/dropbox | 3.0.0-beta | @uppy/transloadit | 3.0.0-beta | | @uppy/facebook | 3.0.0-beta | @uppy/tus | 3.0.0-beta | | @uppy/file-input | 3.0.0-beta | @uppy/unsplash | 3.0.0-beta | | @uppy/form | 3.0.0-beta | @uppy/url | 3.0.0-beta | | @uppy/golden-retriever | 3.0.0-beta | @uppy/utils | 5.0.0-beta | | @uppy/google-drive | 3.0.0-beta | @uppy/vue | 3.0.0-beta | | @uppy/image-editor | 3.0.0-beta | @uppy/webcam | 3.0.0-beta | | @uppy/informer | 3.0.0-beta | @uppy/xhr-upload | 3.0.0-beta | | @uppy/instagram | 3.0.0-beta | @uppy/zoom | 3.0.0-beta | | @uppy/locales | 3.0.0-beta | uppy | 3.0.0-beta | | @uppy/onedrive | 3.0.0-beta | | | - meta: temporary adjust release script for the beta (Antoine du Hamel) - meta: disable ESM to CJS transform in dist files (Antoine du Hamel / transloadit#3773) - @uppy/companion: remove `searchProviders` wrapper & move `s3` options (Merlijn Vos / transloadit#3781) - meta: do not test on EOL versions of Node.js (Antoine du Hamel / transloadit#3786) - @uppy/companion: remove support for EOL versions of Node.js (Antoine du Hamel / transloadit#3784) - @uppy/react: refactor to ESM (Antoine du Hamel / transloadit#3780) - @uppy/transloadit: remove IE 10 hack (Antoine du Hamel / transloadit#3777)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes all the hacks that needed to happen in order to ship working CJS code. Onwards, we plan to distribute Uppy packages as ESM.